Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] sale_report_country_state: Migration to 13.0 #112

Merged
merged 4 commits into from
May 25, 2021

Conversation

joao-p-marques
Copy link
Member

@Tecnativa
TT27872

@chienandalu @pedrobaeza can you review please?

@joao-p-marques joao-p-marques force-pushed the 13.0-mig-sale_report_country_state branch from ec16ad8 to 62ff243 Compare May 24, 2021 10:45
@pedrobaeza pedrobaeza added this to the 13.0 milestone May 25, 2021
@pedrobaeza pedrobaeza mentioned this pull request May 25, 2021
6 tasks
{
"name": "Sale Report Filter by State",
"version": "13.0.1.0.0",
"author": "Tecnativa," "Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "Tecnativa," "Odoo Community Association (OCA)",
"author": "Tecnativa, Odoo Community Association (OCA)",

Comment on lines 35 to 40

#~ msgid "All sales orders grouped by sales channels"
#~ msgstr "Todos los pedidos de venta agrupados por canal"

#~ msgid "Sales Orders Statistics"
#~ msgstr "Estadísticas de pedidos de ventas"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#~ msgid "All sales orders grouped by sales channels"
#~ msgstr "Todos los pedidos de venta agrupados por canal"
#~ msgid "Sales Orders Statistics"
#~ msgstr "Estadísticas de pedidos de ventas"

Comment on lines 43 to 44
#. Go to *Sales > Reporting > All Channels Sales Orders*
#. Filter by State.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't exist anymore

_inherit = "report.all.channels.sales"

state_id = fields.Many2one(
comodel_name="res.country.state", string="Partner's State", readonly=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Customer State so it's grouped altogether with the other partner's properties

image

@joao-p-marques joao-p-marques force-pushed the 13.0-mig-sale_report_country_state branch from 62ff243 to 1607bb6 Compare May 25, 2021 09:28
@joao-p-marques
Copy link
Member Author

Thanks @chienandalu @victoralmau

Changes done!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-112-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 44c69c6 into OCA:13.0 May 25, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6871c49. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants