7.0 sales analysis reporting in base currency #25

llacroix · 2015-03-24T14:05:27Z

No description provided.

sales_analysis_reporting_in_base_currency - sales_analysis_reporting_in_base_currency_inherited - sales_analysis_converting_sale_order_line_in_base_currency

…'t valid

The editor open a form view. We have to add an invisible field to catch the on change events. Also added a total converted to the form view.

It might not be a good idea to store the fields yet. Stored fields are computed only once and have to be recalculated.

joaoalf · 2015-03-24T18:53:49Z

@llacroix Can you please add some tests?

llacroix · 2015-03-24T18:54:54Z

ok

joaoalf · 2015-03-25T13:32:08Z

sales_analysis_reporting_in_base_currency_inherited/report/sale_report.py

@@ -0,0 +1,89 @@
+from openerp import tools


joaoalf · 2015-04-01T20:44:51Z

sales_analysis_converting_sale_order_line_in_base_currency/models/sale_order.py

+    _inherit = 'sale.order.line'
+
+    _columns = {
+        "order_line_currency": fields.many2one(


@llacroix It's not mandatory but I would go with the name currency_id. We know that we are in the order line so the order-line_; prefix is not that relevant and since it's many2one it's more clear to have the _id suffix.

Alright. I'm good with currency_id too

coveralls · 2015-04-03T17:04:46Z

Coverage increased (+11.76%) to 60.0% when pulling 5135cf2 on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

llacroix · 2015-04-03T20:38:23Z

😄

coveralls · 2015-04-03T21:16:45Z

Coverage increased (+24.4%) to 72.63% when pulling a2ece1d on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

coveralls · 2015-04-03T21:16:46Z

Coverage increased (+24.4%) to 72.63% when pulling a2ece1d on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

matches the original price

llacroix · 2015-04-03T22:10:07Z

Maxed the coverage.

…form view

coveralls · 2015-04-17T15:15:17Z

Coverage increased (+28.61%) to 76.84% when pulling 090fc5b on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

coveralls · 2015-04-17T15:15:17Z

Coverage increased (+28.61%) to 76.84% when pulling 090fc5b on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

Even if the rounding for subtotal is set to two while price unit is 5, OpenERP will keep 5 digits everywhere until it gets to the database or the view. For this reason, we have to do roundings by ourselves in some places. In this case, OpenERP seems to be summing the rounded subtotals instead of doing a sum on all lines and then rounding.

coveralls · 2015-04-23T15:47:54Z

Coverage increased (+28.73%) to 76.96% when pulling 716d97a on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

coveralls · 2015-04-23T15:47:54Z

Coverage increased (+28.73%) to 76.96% when pulling 716d97a on savoirfairelinux:7.0-sales_analysis_reporting_in_base_currency into 6596f52 on OCA:7.0.

eLBati · 2015-07-19T16:03:01Z

Hi @llacroix
as module description says

This total is wrong
if you have made sales in different currencies as
Odoo ignores currencies in this instance

Shouldn't this be fixed in the core module?

gurneyalex · 2015-12-31T12:34:31Z

sales_analysis_converting_sale_order_line_in_base_currency/__openerp__.py

+{
+    'name': 'sales Analysis converting sale order line in base currency',
+    'version': '0.1',
+    'author': 'Savoir-faire Linux',


add Odoo Community Association (OCA)

llacroix · 2015-12-31T17:59:47Z

@eLBati It's been a long time... Obviously it should be fixed in the core modules but that would also mean that queries would be probably much more complicated than "fetch" and "show".

eLBati · 2016-01-26T11:51:49Z

@llacroix I made something similar for invoice analysis: odoo/odoo#7550
Would that approach be followable/correct?

pedrobaeza · 2018-04-28T23:44:07Z

This is very old and without further activity, so I'm closing. If you are still interested in this, feel free to reopen it.

llacroix added 10 commits February 20, 2015 14:59

[#63600] Init module convert and save price in base currency

cb6370d

[#63600] Added report

f970f99

[#63600] Split the module in 3 modules

2837923

sales_analysis_reporting_in_base_currency - sales_analysis_reporting_in_base_currency_inherited - sales_analysis_converting_sale_order_line_in_base_currency

[#63600] Fix names and errors for confirming lines

6e7de20

[#63600] Add predicate tests we can't always get the value

094093a

[#63600] Prevent some fields from being added as default if they aren…

3b36790

…'t valid

[#68603] Added converted total to form view

95ce9c2

[#68603] Added support to non editable order_lines.

ae6d321

The editor open a form view. We have to add an invisible field to catch the on change events. Also added a total converted to the form view.

Added converted subtotal one sale order lines and fixed somme issues

bf7768c

It might not be a good idea to store the fields yet. Stored fields are computed only once and have to be recalculated.

Add context to methods

06b29d3

joaoalf added the needs review label Mar 24, 2015

llacroix added 3 commits March 25, 2015 00:12

Added tests that check if reports are being generated and have the field

5134a4c

Added more test to check conversion

9fbe6f2

Flake8 errors

365a28d

joaoalf reviewed Mar 25, 2015
View reviewed changes

sales_analysis_reporting_in_base_currency_inherited/report/sale_report.py

@@ -0,0 +1,89 @@

from openerp import tools

Copy link

joaoalf Mar 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright?

llacroix added 2 commits March 25, 2015 19:51

Improved tests and review from PR

f01aa43

Added more copyright

cf235d9

llacroix force-pushed the 7.0-sales_analysis_reporting_in_base_currency branch from 8678153 to cf235d9 Compare March 25, 2015 16:55

llacroix added 3 commits March 25, 2015 20:01

Fix dependencies in openerp.py

d8f0887

Fix PEP8 errors

52fc643

Added total with currencies to tree view

aa69ab6

joaoalf reviewed Apr 1, 2015
View reviewed changes

Added more tests

a2ece1d

llacroix added 3 commits April 4, 2015 00:30

Added more tests

ba26492

Test what happens when no currency is sent for lines and if price

c307968

matches the original price

Cast division to float for python2 integer division

7bc8fe8

llacroix added 3 commits April 16, 2015 01:38

Use the "Price Unit" as precision.

ea5ecc6

Changed the label of "Converted Amount" and removed Company currency …

1fbc13d

…form view

Fix roundings

090fc5b

llacroix force-pushed the 7.0-sales_analysis_reporting_in_base_currency branch from 40129a5 to fc12487 Compare April 17, 2015 16:43

Fixed PEP8 error

716d97a

gurneyalex reviewed Dec 31, 2015
View reviewed changes

gurneyalex added needs fixing 7.0 labels Dec 31, 2015

max3903 added this to the 7.0 milestone Feb 11, 2016

max3903 removed 7.0 needs review labels Feb 11, 2016

pedrobaeza closed this Apr 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.0 sales analysis reporting in base currency #25

7.0 sales analysis reporting in base currency #25

llacroix commented Mar 24, 2015

joaoalf commented Mar 24, 2015

llacroix commented Mar 24, 2015

joaoalf Mar 25, 2015

joaoalf Apr 1, 2015

llacroix Apr 1, 2015

coveralls commented Apr 3, 2015

llacroix commented Apr 3, 2015

coveralls commented Apr 3, 2015

coveralls commented Apr 3, 2015

llacroix commented Apr 3, 2015

coveralls commented Apr 17, 2015

coveralls commented Apr 17, 2015

coveralls commented Apr 23, 2015

coveralls commented Apr 23, 2015

eLBati commented Jul 19, 2015

gurneyalex Dec 31, 2015

llacroix commented Dec 31, 2015

eLBati commented Jan 26, 2016

pedrobaeza commented Apr 28, 2018

7.0 sales analysis reporting in base currency #25

7.0 sales analysis reporting in base currency #25

Conversation

llacroix commented Mar 24, 2015

joaoalf commented Mar 24, 2015

llacroix commented Mar 24, 2015

joaoalf Mar 25, 2015

Choose a reason for hiding this comment

joaoalf Apr 1, 2015

Choose a reason for hiding this comment

llacroix Apr 1, 2015

Choose a reason for hiding this comment

coveralls commented Apr 3, 2015

llacroix commented Apr 3, 2015

coveralls commented Apr 3, 2015

coveralls commented Apr 3, 2015

llacroix commented Apr 3, 2015

coveralls commented Apr 17, 2015

coveralls commented Apr 17, 2015

coveralls commented Apr 23, 2015

coveralls commented Apr 23, 2015

eLBati commented Jul 19, 2015

gurneyalex Dec 31, 2015

Choose a reason for hiding this comment

llacroix commented Dec 31, 2015

eLBati commented Jan 26, 2016

pedrobaeza commented Apr 28, 2018