[10.0][FIX] avoid reports with empty rows #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix to avoid having empty rows on the QWeb sale order report that relate to the formatted_note field. If the field has no content, it shouldn't be displayed. Also note that the default formatted_note content is <p><br></p> and so we also need to prevent printing when the field has that value.
|
But that are not empty rows... They have some HTML content. How did you come to this situation? |
|
The default for html fields is:
I have that value on every order line. It certainly is html content but nevertheless is not something that the user entered so it should be considered as a form of "empty". |
|
OK, I see that indeed that default value is added, but please don't reindent the XML. Just change the affected line. |
|
@pedrocasi |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to avoid having empty rows on the QWeb sale order
report that relate to the formatted_note field. If the field has no
content, it shouldn't be displayed. Also note that the default
formatted_note content is
and so we also need to preventprinting when the field has that value.