Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_layout_category_hide_detail: Migration to 13.0 #76

Merged
merged 9 commits into from
Dec 30, 2019
Merged

[MIG] sale_layout_category_hide_detail: Migration to 13.0 #76

merged 9 commits into from
Dec 30, 2019

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Nov 18, 2019

No description provided.

@TDu TDu mentioned this pull request Nov 18, 2019
Merged
@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 18, 2019
pedrobaeza
pedrobaeza requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a75e007 here

sale_layout_category_hide_detail/migrations/12.0.1.0.0/pre-migration.py Outdated Show resolved Hide resolved
@TDu
Copy link
Member

TDu commented Nov 21, 2019

Black seems to be weirdly configured ! Asking for lines longer than 80 char 😕

@pedrobaeza
Copy link
Member

Black seems to be weirdly configured ! Asking for lines longer than 80 char

Line length is no longer a requirement. We let black to decide. That's why now there's no such linter to put in red if exceeded.

@TDu
Copy link
Member

TDu commented Nov 21, 2019

Thanks for the explanation, that line length really surprised me :)

@ernestotejeda ernestotejeda mentioned this pull request Nov 22, 2019
Closed
@ernestotejeda
Copy link
Member

LGTM 👍

@pedrobaeza
Copy link
Member

Can you please squash migrations commits together and I'll proceed to merge?

ernestotejeda and others added 9 commits December 30, 2019 16:56
@ernestotejeda @pedrobaeza
sale_layout_category_hide_detail: New module
11ee37d 
Hide details for sections in sales orders and invoices for reports and
customer portal
@mvrodriguez @pedrobaeza
Translated using Weblate (Spanish)
915fb59 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-reporting-11.0/sale-reporting-11.0-sale_layout_category_hide_detail
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-11-0/sale-reporting-11-0-sale_layout_category_hide_detail/es/
@ernestotejeda @pedrobaeza
[MIG] sale_layout_category_hide_detail: Migration to 12.0
842d7c2
@pedrobaeza
[MIG] sale_layout_category_hide_detail: Migration scripts
ee12dec
@sebalix @pedrobaeza
[IMP] sale_layout_category_hide_detail: black, isort
a54da62
@sebalix @pedrobaeza
[MIG] sale_layout_category_hide_detail: Migration to 13.0
03acb8d
@ernestotejeda @pedrobaeza
[FIX] sale_layout_category_hide_detail: Propagate 'Show details' to i…
db96faf 
…nvoice"

Propagate values in 'Show details' and 'Show subtotal' fields from Sale Order Lines to Invoice Lines
@TDu @pedrobaeza
[FIX] sale_layout_category_hide_detail: Column rendering in section +…
6dd6b7c 
… tests + linting + JS for column not in fieldsInfo list
@pedrobaeza
[FIX] sale_layout_category_hide_detail: Missing condition
ecae5e8 
If a note line is put in first position, we get an error due to this missing condition.
@pedrobaeza pedrobaeza force-pushed the 13.0-mig-sale_layout_category_hide_detail branch from 4af440e to ecae5e8 Compare December 30, 2019 16:03
pedrobaeza
pedrobaeza approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have squashed myself and add also 1c7a923 that is something I have fixed for 12.0

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-76-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 30, 2019
@OCA-git-bot
Merge PR #76 into 13.0
6bada15 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 30, 2019
Closed
6 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit ecae5e8 into OCA:13.0 Dec 30, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1414f45. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@ernestotejeda ernestotejeda ernestotejeda approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sebalix @TDu @pedrobaeza @ernestotejeda @OCA-git-bot @mvrodriguez