Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of sale_line_price_properties_based #145

Merged
merged 10 commits into from
Jun 9, 2017
Merged

Migration of sale_line_price_properties_based #145

merged 10 commits into from
Jun 9, 2017

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented May 5, 2015 •
edited by gurneyalex

This PR depends on #147 which also depends on #167 (both merged)

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.94%) to 70.65% when pulling 726c362 on tafaRU:8.0-sale_line_price_properties_based-migr into 8b0e50b on OCA:8.0.

@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch from 1186300 to dce8fb6 Compare June 19, 2015 09:59
@tafaRU tafaRU mentioned this pull request Nov 16, 2015
Merged
@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch 2 times, most recently from bf98cc4 to fc593e9 Compare November 16, 2015 11:41
@tafaRU tafaRU mentioned this pull request Nov 16, 2015
Merged
@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch 3 times, most recently from 8e0de66 to e5fc886 Compare November 17, 2015 11:37
@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch from e5fc886 to 73f9674 Compare November 25, 2015 10:09
gurneyalex
gurneyalex reviewed Nov 25, 2015
View reviewed changes
sale_line_price_properties_based/product.py Outdated
compute_formula(localdict)
except ValueError as e:
_logger.warning(
"Formula evaluation error: '%s'" % e.message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's a good idea to silence the error here. Since the user can edit the formula, he should get some feedback about evaluation errors without having to browse the server logs.

@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch from 73f9674 to 37c9b25 Compare February 26, 2016 14:14
@gurneyalex
Copy link
Member

@tafaRU I split the tests of the addon so that they don't conflict in tafaRU#5. I'm still concerned about the wild incompatibilities we have in this repository (not your fault).

@tafaRU
Copy link
Member Author

tafaRU commented Oct 6, 2016 •
edited

@gurneyalex I've just merged your PR, let's see the travis build result.
Thanks!

@pedrobaeza
Copy link
Member

Travis is still red

@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch from 89061a7 to f1f43db Compare February 17, 2017 15:34
@eLBati
Copy link
Member

eLBati commented Mar 10, 2017

@tafaRU is this ready?

@tafaRU
Copy link
Member Author

tafaRU commented Mar 10, 2017

@tafaRU is this ready?

@eLBati, yes, finally 😄

eLBati
eLBati approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(A little squash is welcome)

@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch 2 times, most recently from e790ebd to d5f28c3 Compare May 31, 2017 09:06
tafaRU and others added 2 commits May 31, 2017 11:07
@tafaRU
Migrate sale_line_price_properties_based to 8.0
8896bc9 
Fix field name, changed in V8

Inherit views from sale_mrp instead of sale_stock

Update copyright year

Extract the description in README.rst

Change version and remove deprecated key as active

Use CamelCase notation for model

Add OCA icon

Remove redundant record: this assignment is already done in 'view_order_form_inherit'
@eLBati @tafaRU
[FIX] using new API for property_ids onchange
669365c
tafaRU and others added 6 commits May 31, 2017 11:07
@tafaRU
Fix onchange method name and add check on product_id
8d4bdfc
@tafaRU
Fix wrong interoperability among onchange (v8) and on_change (v7).
8e30796 
To do this I apply the following changes:
- depends from sale_properties_dynamic_fields instead of sale_properties_easy_creation
- onchange (v8) only depends by property_ids
- get empty properties and get empty properties dynamic fields in on_change (v7)
@tafaRU
Add sale_order_view.xml to remove on_change on product_uom_qty
b14de65
@tafaRU
Calculate price by using compute_formula method
a0e8444
@tafaRU
[ADD] sale_line_price_properties_based: add uos_id to localdict
c4b89f7
@gurneyalex @tafaRU
split the travis tests
ddbcc97
@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch from d5f28c3 to dc811e2 Compare May 31, 2017 09:07
@tafaRU tafaRU force-pushed the 8.0-sale_line_price_properties_based-migr branch from dc811e2 to f0c2478 Compare May 31, 2017 09:09
@tafaRU
Copy link
Member Author

tafaRU commented May 31, 2017

@eLBati, squashed a bit.

@rafaelbn
Copy link
Member

Hi @tafaRU are you going to continue with this PR?

@tafaRU
Copy link
Member Author

tafaRU commented May 31, 2017 •
edited

@rafaelbn, yes, of course! Before​ the rebase I had this morning, Travis was green. I'll check it deeply in the next days.

@tafaRU
Copy link
Member Author

tafaRU commented Jun 7, 2017

@rafaelbn, just restarted the build and now Travis looks green again!

@rafaelbn
Copy link
Member

rafaelbn commented Jun 9, 2017

@tafaRU are you going to squash anything else?

@tafaRU
Copy link
Member Author

tafaRU commented Jun 9, 2017 •
edited

@rafaelbn, I would keep the history commits as is. Thanks!

@rafaelbn rafaelbn merged commit 0521fcd into OCA:8.0 Jun 9, 2017
ernestotejeda pushed a commit to Tecnativa/sale-workflow that referenced this pull request Aug 22, 2019
@nicomacr @ernestotejeda
[REL] migration product_pack to 11.0 (OCA#145)
600df19 
* [FIX] xml files names

* [REL] migration product_pack to 11.0
* [FIX] Update README
* [FIX] remove openerp tags and data tags
* [IMP] change some funtion to improve funcionality
* [FIX] change name to xml and .py files according guidelines
* [FIX] remove api.one decorators

* [FIX] update readme

* [FIX] Remove "encoding: utf-8"

* [FIX] remove api.multi, string not necesary and some other fixes

* [FIX] demo data to separate according Guidelines

* [FIX] fix names in fields

* [FIX] remove executable
ernestotejeda pushed a commit to Tecnativa/sale-workflow that referenced this pull request Aug 27, 2019
@nicomacr @ernestotejeda
[REL] migration product_pack to 11.0 (OCA#145)
5fc20bd 
* [FIX] xml files names

* [REL] migration product_pack to 11.0
* [FIX] Update README
* [FIX] remove openerp tags and data tags
* [IMP] change some funtion to improve funcionality
* [FIX] change name to xml and .py files according guidelines
* [FIX] remove api.one decorators

* [FIX] update readme

* [FIX] Remove "encoding: utf-8"

* [FIX] remove api.multi, string not necesary and some other fixes

* [FIX] demo data to separate according Guidelines

* [FIX] fix names in fields

* [FIX] remove executable
ernestotejeda pushed a commit to Tecnativa/sale-workflow that referenced this pull request Sep 16, 2019
@nicomacr @ernestotejeda
[REL] migration product_pack to 11.0 (OCA#145)
5bc0606 
* [FIX] xml files names

* [REL] migration product_pack to 11.0
* [FIX] Update README
* [FIX] remove openerp tags and data tags
* [IMP] change some funtion to improve funcionality
* [FIX] change name to xml and .py files according guidelines
* [FIX] remove api.one decorators

* [FIX] update readme

* [FIX] Remove "encoding: utf-8"

* [FIX] remove api.multi, string not necesary and some other fixes

* [FIX] demo data to separate according Guidelines

* [FIX] fix names in fields

* [FIX] remove executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tafaRU @coveralls @gurneyalex @pedrobaeza @eLBati @rafaelbn