[8.0] Migration of sale_properties_easy_creation #167
Conversation
|
👍 |
| This allows the user to digit 'width 0.5' and the system will | ||
| automatically create a property of group 'width' with value '0.5' | ||
| """ | ||
| splitted_name = name.split(' ') |
There was a problem hiding this comment.
I suggest using name.split() here, as this will properly handle multiple spaces, tabs, etc.
|
@gurneyalex thanks for your hint. I temporarily set the PR as WIP. |
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
…ich depending on it
tafaRU
force-pushed
the
8.0-sale_properties_easy_creation
branch
from
e48be69
to
b405933
Compare
|
@gurneyalex, your remarks have been addressed, could you please have a look at it? Thank you in advance. |
|
Tried to test the module on runbot, and IMO the README.rst could be improved a little bit by mentionning the ir.config to activate to get access to the proper settings, and such. Also the formula_txt field should provide a help to describe how to write a formula (which variables are available etc. ) Finally there is no call to compute_formula in there. Is this intended? |
Could be further improved, but:
Yes, this is intended. |
|
👍 |
[8.0] Migration of sale_properties_easy_creation
No description provided.