Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of sale_properties_dynamic_fields #147

Merged
merged 15 commits into from
Nov 25, 2015
Merged

Migration of sale_properties_dynamic_fields #147

merged 15 commits into from
Nov 25, 2015

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented May 5, 2015

This PR depends on #167 (merged now)

This was referenced Jun 30, 2015
Merged
Merged
@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 4a1f25d to 3b942a8 Compare November 16, 2015 10:47
@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 0b0944b to 7a43f44 Compare November 17, 2015 08:43
@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 7a43f44 to 73a9dd7 Compare November 17, 2015 08:48
@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 70e405a to e061d48 Compare November 17, 2015 10:06
@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 268d802 to 4e49bbd Compare November 17, 2015 13:12
@tafaRU
Copy link
Member Author

tafaRU commented Nov 17, 2015

@gurneyalex, all Travis builds are finally green!
Coverage decreased due to 484a8a7.

gurneyalex
gurneyalex reviewed Nov 18, 2015
View reviewed changes
sale_properties_dynamic_fields/sale_order_line.py
('field_id', '=', field_ids[0]),
], context=context)
if len(group_ids) != 1:
raise orm.except_orm(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use openerp.exceptions.Warning

gurneyalex
gurneyalex reviewed Nov 18, 2015
View reviewed changes
sale_properties_dynamic_fields/sale_order.py
on_change="dynamic_property_changed(property_ids, %s, "
"context)"
% (field_name),
context="{\'field_name\': \'%s\'}" % field_name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backslashes are not required

@gurneyalex
Copy link
Member

some refactoring suggested

missing POT file.

@eLBati
Copy link
Member

eLBati commented Nov 18, 2015

On 18 November 2015 at 09:54, Alexandre Fayolle notifications@github.com
wrote:

some refactoring suggested

missing POT file.

Is POT file needed? If I remember correctly, with transifex, it is not
needed anymore. Template module
https://github.com/OCA/maintainer-tools/tree/master/template/module does
not contain it

@gurneyalex
Copy link
Member

not sure about transifex. @pedrobaeza do you know the answer?

@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch 2 times, most recently from bdd2d8f to 5f873ee Compare November 19, 2015 16:01
@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 5f873ee to a031d13 Compare November 19, 2015 16:02
@tafaRU
Copy link
Member Author

tafaRU commented Nov 19, 2015

@gurneyalex. your remarks have been addressed. Please have a look at it.

@eLBati
Copy link
Member

eLBati commented Nov 20, 2015

Thanks 👍

@tafaRU tafaRU force-pushed the 8.0-sale_properties_dynamic_fields-migr branch from 9882430 to 43ef0aa Compare November 25, 2015 09:35
@gurneyalex
Copy link
Member

👍

gurneyalex added a commit that referenced this pull request Nov 25, 2015
@gurneyalex
Merge pull request #147 from tafaRU/8.0-sale_properties_dynamic_field…
88f230b 
…s-migr

Migration of sale_properties_dynamic_fields
@gurneyalex gurneyalex merged commit 88f230b into OCA:8.0 Nov 25, 2015
@yajo
Copy link
Member

yajo commented Feb 22, 2016

Could somebody from here please check #226 (comment)? Thanks.

lmignon pushed a commit to acsone/sale-workflow that referenced this pull request Feb 11, 2021
@simahawk
Merge pull request OCA#147 from camptocamp/13.0-fix-zero-check
6802312 
[13.0] Shopfloor Zone Picking: fix zero check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tafaRU @gurneyalex @eLBati @yajo @lepistone @elicoidal