Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][8.0] sale_service_fleet: New module. #227

Merged
merged 6 commits into from
Mar 2, 2016
Merged

[ADD][8.0] sale_service_fleet: New module. #227

merged 6 commits into from
Mar 2, 2016

Conversation

sergio-teruel
Copy link
Contributor

This module was written to extends the functionality of sale service project and allow you to assign a vehicle to a sale order, so when the project is created the vehicle is assigned to it

This module depends in #226

@rafaelbn rafaelbn added this to the 8.0 milestone Dec 9, 2015
@rafaelbn rafaelbn self-assigned this Dec 9, 2015
@rafaelbn
Copy link
Member

rafaelbn commented Dec 9, 2015

Please @sergio-incaser rebase and check travis, we will check runbot after #226 is merged, thanks!

@rafaelbn
Copy link
Member

Please rebase, thanks

@carlosdauden
Copy link
Contributor

@rafaelbn rebased

@rafaelbn
Copy link
Member

I have tested this module in local and is in customer's production environment. functionally is 👍

could you say me is Travis errors is the same reason as #226 (comment)?

Thanks

@carlosdauden
Copy link
Contributor

Yes @rafaelbn. Travis fails by the same reason as #226 (comment) and a new not related test error is showed now:

2016-02-23 14:51:38,335 23832 ERROR openerp_test openerp.addons.sale_order_lot_selection.tests.test_sale_order_lot_selection: File "/home/travis/odoo-8.0/addons/stock/wizard/stock_transfer_details.py", line 79, in do_detailed_transfer 2016-02-23 14:51:38,335 23832 ERROR openerp_test openerp.addons.sale_order_lot_selection.tests.test_sale_order_lot_selection: raise Warning(_('You cannot transfer a picking in state \'%s\'.') % self.picking_id.state) 2016-02-23 14:51:38,335 23832 ERROR openerp_test openerp.addons.sale_order_lot_selection.tests.test_sale_order_lot_selection: openerp.exceptions.Warning: You cannot transfer a picking in state 'False'.

Sale Service Fleet
==================

This module was written to extends the functionality of sale service project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"extend"

@yajo
Copy link
Member

yajo commented Feb 24, 2016

Code seems quite good, wating for runbot to try it.

@sergio-teruel
Copy link
Contributor Author

@yajo @rafaelbn Changes done and waiting for travis...


To use this module, you need to:

1. Create a vehicle in fleet menu and assign it to a sale order.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the code many more functionalities. Could you explain yourself better please? Just to know what am I supposed to test in the runbot.

…rvice_fleet

Conflicts:
	sale_service_fleet/README.rst
	sale_service_fleet/report/project_report.py
@rafaelbn
Copy link
Member

Travis still fails 😢 , please take a review in explaining a little bit more. Thanks!

@rafaelbn
Copy link
Member

Absolutely great and clean! 👍

@yajo
Copy link
Member

yajo commented Feb 26, 2016

👍

class FleetVehicle(models.Model):
_inherit = "fleet.vehicle"

project_ids = fields.One2many(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why projects and not analytic accounts?

@carlosdauden
Copy link
Contributor

@pedrobaeza changes done

@pedrobaeza
Copy link
Member

Please remove pot file and regenerate es.po one (for the new field).

@carlosdauden
Copy link
Contributor

@pedrobaeza string changed an translated

@pedrobaeza
Copy link
Member

👍

pedrobaeza added a commit that referenced this pull request Mar 2, 2016
[ADD][8.0] sale_service_fleet: New module.
@pedrobaeza pedrobaeza merged commit b103f72 into OCA:8.0 Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants