-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD][8.0] sale_service_fleet: New module. #227
Conversation
Please @sergio-incaser rebase and check travis, we will check runbot after #226 is merged, thanks! |
Please rebase, thanks |
@rafaelbn rebased |
I have tested this module in local and is in customer's production environment. functionally is 👍 could you say me is Travis errors is the same reason as #226 (comment)? Thanks |
Yes @rafaelbn. Travis fails by the same reason as #226 (comment) and a new not related test error is showed now:
|
Sale Service Fleet | ||
================== | ||
|
||
This module was written to extends the functionality of sale service project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"extend"
Code seems quite good, wating for runbot to try it. |
|
||
To use this module, you need to: | ||
|
||
1. Create a vehicle in fleet menu and assign it to a sale order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in the code many more functionalities. Could you explain yourself better please? Just to know what am I supposed to test in the runbot.
…rvice_fleet Conflicts: sale_service_fleet/README.rst sale_service_fleet/report/project_report.py
Travis still fails 😢 , please take a review in explaining a little bit more. Thanks! |
Absolutely great and clean! 👍 |
👍 |
class FleetVehicle(models.Model): | ||
_inherit = "fleet.vehicle" | ||
|
||
project_ids = fields.One2many( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why projects and not analytic accounts?
@pedrobaeza changes done |
Please remove pot file and regenerate es.po one (for the new field). |
@pedrobaeza string changed an translated |
👍 |
[ADD][8.0] sale_service_fleet: New module.
This module was written to extends the functionality of sale service project and allow you to assign a vehicle to a sale order, so when the project is created the vehicle is assigned to it
This module depends in #226