-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] sale_order_general_discount: migration to 16.0 #2318
[MIG] sale_order_general_discount: migration to 16.0 #2318
Conversation
017e91a
to
1fd930c
Compare
a092454
to
1af50e7
Compare
1af50e7
to
67860d4
Compare
…unt for all sale order lines
…nes created without UI form view
[MIG] Migrated sale_order_general_discount to v13. [IMP] Improved code as per request. [IMP][13.0] sale_order_general_discount: rebase with OCA/13.0 + apply pre-commit [UPD] sale_order_general_discount: update view to display percentage correctly
version conflict prevents upload to pypi
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_general_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_general_discount/it/
67860d4
to
51d1e1f
Compare
/ocabot migration sale_order_general_discount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
@ferran-S73 Could you attract some people to review this ? |
Hi @stefan-tecnativa @chienandalu @pedrobaeza this is a straightforward port from v15 could you please add your review? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test 👍 Thanks!
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test working fine!
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 80372bc. Thanks a lot for contributing to OCA. ❤️ |
No description provided.