Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] sale_order_general_discount: migration to 16.0 #2318

Merged
merged 17 commits into from
Apr 19, 2023

Conversation

ferran-S73
Copy link
Contributor

No description provided.

@ferran-S73 ferran-S73 mentioned this pull request Dec 28, 2022
97 tasks
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_order_general_discount branch from 017e91a to 1fd930c Compare December 28, 2022 15:45
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_order_general_discount branch 2 times, most recently from a092454 to 1af50e7 Compare January 27, 2023 07:57
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_order_general_discount branch from 1af50e7 to 67860d4 Compare April 17, 2023 07:29
sergio-teruel and others added 17 commits April 17, 2023 09:35
[MIG] Migrated sale_order_general_discount to v13.

[IMP] Improved code as per request.

[IMP][13.0] sale_order_general_discount: rebase with OCA/13.0 + apply pre-commit

[UPD] sale_order_general_discount: update view to display percentage correctly
version conflict prevents upload to pypi
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_general_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_general_discount/it/
@ferran-S73 ferran-S73 force-pushed the 16.0-mig-sale_order_general_discount branch from 67860d4 to 51d1e1f Compare April 17, 2023 07:36
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_general_discount

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Contributor

@ferran-S73 Could you attract some people to review this ?

@ferran-S73
Copy link
Contributor Author

Hi @stefan-tecnativa @chienandalu @pedrobaeza this is a straightforward port from v15 could you please add your review? Thank you

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍 Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@stefan-tecnativa stefan-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test working fine!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2318-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 407d359 into OCA:16.0 Apr 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 80372bc. Thanks a lot for contributing to OCA. ❤️

@RabbitJon-S73 RabbitJon-S73 deleted the 16.0-mig-sale_order_general_discount branch May 25, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.