Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sale_order_general_discount: apply discount only on gener… #2524

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ferran-S73
Copy link
Contributor

…al discount apply product option

Forward port from

@ferran-S73 ferran-S73 force-pushed the 16.0-imp-sale_general_discount branch 3 times, most recently from af08604 to 7cb2d52 Compare May 23, 2023 07:04
@ferran-S73 ferran-S73 force-pushed the 16.0-imp-sale_general_discount branch from 7cb2d52 to 4e98518 Compare June 28, 2023 09:02
Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funtional review. LG!

@petrus-v
Copy link

Thanks to have port this work, unfortunately this PR #2685 has been merged before and do a similar job, so just to tell you that I've closed the initial PR (#1812) on version 14.0, It would be probably better to port the merged PR (#2685) to make easier maintenance over versions !

@hildickethan hildickethan force-pushed the 16.0-imp-sale_general_discount branch 2 times, most recently from 8d0b2ea to c10bf39 Compare March 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants