15.0 mig sale restricted qty #2581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration sale_restricted_qty |
thinkwelltwd
force-pushed
the
15.0-mig-sale_restricted_qty
branch
6 times, most recently
from
57b0843
to
0d2c40e
Compare
|
Thanks for the review! Should be ready to merge now. |
|
We need here functional reviews for sale_restricted_qty module /ocabot rebase |
|
Congratulations, PR rebased to 15.0. |
OCA-git-bot
force-pushed
the
15.0-mig-sale_restricted_qty
branch
from
0d2c40e
to
18f6cb7
Compare
|
Hello @rousseldenis , your comments have been attended! @thinkwelltwd please review why pre-commit is failing! Thank you! 👍🏼 |
thinkwelltwd
force-pushed
the
15.0-mig-sale_restricted_qty
branch
4 times, most recently
from
9116661
to
53f7f8b
Compare
thinkwelltwd
force-pushed
the
15.0-mig-sale_restricted_qty
branch
from
53f7f8b
to
61aa98f
Compare
|
Could @rousseldenis or someone else please review this PR? The tests are all passing and it represents quite a lot of cleanup to the module. 🙏 |
rousseldenis
approved these changes
Nov 6, 2023
|
All requested changes have been made and approved. The code has been used in production for weeks. Could this PR be merged? 🙏 |
|
/ocabot rebase |
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/fr/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/fr/
Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/
Improve grammar and spelling Optimize test by setting up test class once Remove product_product_views.xml view since the product_template_views.xml view adds needed fields
|
Congratulations, PR rebased to 15.0. |
OCA-git-bot
force-pushed
the
15.0-mig-sale_restricted_qty
branch
from
61aa98f
to
dc4c68b
Compare
|
Please, could you review in runbot showing how this works? 😄 I've tested and it doesn't look like working
|
|
@thinkwelltwd Do you mind if we switch to #2992 ? |
Sure, go ahead. Thanks for asking. 😄 |
|
Superseded by #2992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate module as well as improve grammar and spelling
Optimize test by setting up test class once
Remove product_product_views.xml view since the product_template_views.xml view adds needed fields