Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] sale_substate #2599

Merged
merged 17 commits into from
Jul 12, 2023
Merged

[14.0][MIG] sale_substate #2599

merged 17 commits into from
Jul 12, 2023

Conversation

aleuffre
Copy link

@aleuffre aleuffre commented Jul 10, 2023 •
edited
Loading

Superseeds #1435

Took the same commits and simply rebased.

mourad-ehm and others added 16 commits July 10, 2023 14:31
@aleuffre
Copy link
Author

@miguel-S73 @fuentes73 @hitrosol in case you're still interested in this

francesco-ooops
francesco-ooops approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@francesco-ooops
Copy link
Contributor

@mourad-ehm good for you?

Aldeigja
Aldeigja approved these changes Jul 11, 2023
View reviewed changes
Copy link

@Aldeigja Aldeigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francesco-ooops
Copy link
Contributor

@OCA/crm-sales-marketing-maintainers good for merge?

@francesco-ooops
Copy link
Contributor

@simahawk ;)

@dreispt
Copy link
Member

dreispt commented Jul 12, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2599-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 12, 2023
@OCA-git-bot
Merge PR #2599 into 14.0
6956708 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-2599-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 12, 2023
@OCA-git-bot
Merge PR #2599 into 14.0
e527df8 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-2599-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1465c21 into OCA:14.0 Jul 12, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e306689. Thanks a lot for contributing to OCA. ❤️

@aleuffre aleuffre deleted the 14.0-mig-sale-substate branch October 31, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aldeigja Aldeigja Aldeigja approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@miguel-S73 miguel-S73 miguel-S73 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aleuffre @francesco-ooops @dreispt @OCA-git-bot @miguel-S73 @Aldeigja @mourad-ehm @Saran440