Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] pricelist_cache #2601

Closed
wants to merge 7 commits into from

Conversation

juanpgarza
Copy link
Contributor

Standard migration

@rousseldenis
Copy link
Contributor

/ocabot migration pricelist_cache

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanpgarza Could you fix tests ?

@juanpgarza
Copy link
Contributor Author

hi @rousseldenis
I would but I don't know how.
Could you help me a little or point me to a tutorial or webinar on the subject?

@valentincastravete
Copy link

Hi @juanpgarza
Could you re-run the tests so I can lend you a hand please?
Their logs have been deleted.
Thanks!

@valentincastravete
Copy link

Hi @juanpgarza Could you re-run the tests so I can lend you a hand please? Their logs have been deleted. Thanks!

Hi @rousseldenis Could you re-run the tests please? Thanks!

@rousseldenis
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@valentincastravete
Copy link

Hi @juanpgarza
Could you please update your repository with the last updates on the pricelist_cache module on v14 please?
To see it changes anything related to the tests.
Thanks!

Comment on lines +8 to +45
LIST_PRICES_MAPPING = {
"pricelist_cache.list0": [
{"id": 17, "price": 100.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list1": [
{"id": 17, "price": 75.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list2": [
{"id": 17, "price": 50.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list3": [
{"id": 17, "price": 25.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list4": [
{"id": 17, "price": 15.0},
{"id": 18, "price": 50.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list5": [
{"id": 17, "price": 45.0},
{"id": 18, "price": 99.0},
{"id": 19, "price": 120.0},
{"id": 20, "price": 67.0},
],
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LIST_PRICES_MAPPING = {
"pricelist_cache.list0": [
{"id": 17, "price": 100.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list1": [
{"id": 17, "price": 75.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list2": [
{"id": 17, "price": 50.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list3": [
{"id": 17, "price": 25.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list4": [
{"id": 17, "price": 15.0},
{"id": 18, "price": 50.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list5": [
{"id": 17, "price": 45.0},
{"id": 18, "price": 99.0},
{"id": 19, "price": 120.0},
{"id": 20, "price": 67.0},
],
}
LIST_PRICES_MAPPING = {
"pricelist_cache.list0": [
{"id": 17, "price": 100.0},
{"id": 18, "price": 15.8},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list1": [
{"id": 17, "price": 75.0},
{"id": 18, "price": 15.8},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list2": [
{"id": 17, "price": 50.0},
{"id": 18, "price": 15.8},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list3": [
{"id": 17, "price": 25.0},
{"id": 18, "price": 79.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list4": [
{"id": 17, "price": 15.0},
{"id": 18, "price": 50.0},
{"id": 19, "price": 100.0},
{"id": 20, "price": 47.0},
],
"pricelist_cache.list5": [
{"id": 17, "price": 45.0},
{"id": 18, "price": 35.8},
{"id": 19, "price": 120.0},
{"id": 20, "price": 67.0},
],
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juanpgarza
I've found the solution to the tests.
It's caused by the odoo/addons/product module demo data change of a product:

The one used here:
https://github.com/juanpgarza/sale-workflow/blob/15.0-mig-pricelist_cache/pricelist_cache/data/demo.xml#L121
With the ID 18;
image

V14.0:
https://github.com/odoo/odoo/blob/14.0/addons/product/data/product_demo.xml#L285
Price: 79.0

V15.0:
https://github.com/odoo/odoo/blob/15.0/addons/product/data/product_demo.xml#L285
Price: 15.8

After updating the price, the tests passes.

Regards

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis Could you apply this suggestion for him please? So it can be merged

@valentincastravete
Copy link

@rousseldenis Hi, my PR has been merged, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants