-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] pricelist_cache #2601
Conversation
/ocabot migration pricelist_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanpgarza Could you fix tests ?
hi @rousseldenis |
Hi @juanpgarza |
Hi @rousseldenis Could you re-run the tests please? Thanks! |
/ocabot rebase |
Congratulations, PR rebased to 15.0. |
81767b0
to
fbad31e
Compare
Hi @juanpgarza |
LIST_PRICES_MAPPING = { | ||
"pricelist_cache.list0": [ | ||
{"id": 17, "price": 100.0}, | ||
{"id": 18, "price": 79.0}, | ||
{"id": 19, "price": 100.0}, | ||
{"id": 20, "price": 47.0}, | ||
], | ||
"pricelist_cache.list1": [ | ||
{"id": 17, "price": 75.0}, | ||
{"id": 18, "price": 79.0}, | ||
{"id": 19, "price": 100.0}, | ||
{"id": 20, "price": 47.0}, | ||
], | ||
"pricelist_cache.list2": [ | ||
{"id": 17, "price": 50.0}, | ||
{"id": 18, "price": 79.0}, | ||
{"id": 19, "price": 100.0}, | ||
{"id": 20, "price": 47.0}, | ||
], | ||
"pricelist_cache.list3": [ | ||
{"id": 17, "price": 25.0}, | ||
{"id": 18, "price": 79.0}, | ||
{"id": 19, "price": 100.0}, | ||
{"id": 20, "price": 47.0}, | ||
], | ||
"pricelist_cache.list4": [ | ||
{"id": 17, "price": 15.0}, | ||
{"id": 18, "price": 50.0}, | ||
{"id": 19, "price": 100.0}, | ||
{"id": 20, "price": 47.0}, | ||
], | ||
"pricelist_cache.list5": [ | ||
{"id": 17, "price": 45.0}, | ||
{"id": 18, "price": 99.0}, | ||
{"id": 19, "price": 120.0}, | ||
{"id": 20, "price": 67.0}, | ||
], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LIST_PRICES_MAPPING = { | |
"pricelist_cache.list0": [ | |
{"id": 17, "price": 100.0}, | |
{"id": 18, "price": 79.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list1": [ | |
{"id": 17, "price": 75.0}, | |
{"id": 18, "price": 79.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list2": [ | |
{"id": 17, "price": 50.0}, | |
{"id": 18, "price": 79.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list3": [ | |
{"id": 17, "price": 25.0}, | |
{"id": 18, "price": 79.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list4": [ | |
{"id": 17, "price": 15.0}, | |
{"id": 18, "price": 50.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list5": [ | |
{"id": 17, "price": 45.0}, | |
{"id": 18, "price": 99.0}, | |
{"id": 19, "price": 120.0}, | |
{"id": 20, "price": 67.0}, | |
], | |
} | |
LIST_PRICES_MAPPING = { | |
"pricelist_cache.list0": [ | |
{"id": 17, "price": 100.0}, | |
{"id": 18, "price": 15.8}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list1": [ | |
{"id": 17, "price": 75.0}, | |
{"id": 18, "price": 15.8}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list2": [ | |
{"id": 17, "price": 50.0}, | |
{"id": 18, "price": 15.8}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list3": [ | |
{"id": 17, "price": 25.0}, | |
{"id": 18, "price": 79.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list4": [ | |
{"id": 17, "price": 15.0}, | |
{"id": 18, "price": 50.0}, | |
{"id": 19, "price": 100.0}, | |
{"id": 20, "price": 47.0}, | |
], | |
"pricelist_cache.list5": [ | |
{"id": 17, "price": 45.0}, | |
{"id": 18, "price": 35.8}, | |
{"id": 19, "price": 120.0}, | |
{"id": 20, "price": 67.0}, | |
], | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @juanpgarza
I've found the solution to the tests.
It's caused by the odoo/addons/product module demo data change of a product:
The one used here:
https://github.com/juanpgarza/sale-workflow/blob/15.0-mig-pricelist_cache/pricelist_cache/data/demo.xml#L121
With the ID 18;
V14.0:
https://github.com/odoo/odoo/blob/14.0/addons/product/data/product_demo.xml#L285
Price: 79.0
V15.0:
https://github.com/odoo/odoo/blob/15.0/addons/product/data/product_demo.xml#L285
Price: 15.8
After updating the price, the tests passes.
Regards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis Could you apply this suggestion for him please? So it can be merged
@rousseldenis Hi, my PR has been merged, this can be closed. |
Standard migration