-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] sale_stock_line_sequence #2607
[14.0][MIG] sale_stock_line_sequence #2607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: nevermind, is the refactor. Can't do functional test in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LG
/ocabot migration sale_stock_line_sequence |
8ce4ab6
to
5aaf80c
Compare
/ocabot migration sale_stock_line_sequence |
@OriolMForgeFlow Thanks for this. FYI, you can embed your dependency PR here in order to get tests running and runboat for functional testing. |
@OriolMForgeFlow @AaronHForgeFlow I've tested on runboat and if the order of lines change should change the order of invoice lines, that does not work: Sale Order after change: Invoice after sale order change: |
Oops wrong PR. @OriolMForgeFlow This is for #2603 |
Thank you for your feedback, @rousseldenis! The lines in the invoice remain unchanged as we are not utilizing the sequence field, which was causing some issues. Instead, we have introduced a new field called "related_so_sequence," designed as a Char field (SO12345/1 - so_name/sequence). This choice is based on the consideration that an invoice can be generated from multiple Sales Orders. As a result, we cannot use this field to sort the order lines. Here's an example: |
5a252de
to
bd5b98f
Compare
e588bf0
to
20eadd8
Compare
d419a45
to
53f7621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, Works as expected.
e26a12e
to
aab4536
Compare
aab4536
to
d153c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 0c409be. Thanks a lot for contributing to OCA. ❤️ |
Standard migration
Taking into account the refactor done in !2603