[15.0][FIX] sale_order_revision: Users can access the smart button Prev. revision #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtratip
approved these changes
Jul 22, 2023
| @@ -35,7 +35,7 @@ def _prepare_revision_data(self, new_revision): | |||
| def action_view_revisions(self): | |||
| self.ensure_one() | |||
| action = self.env.ref("sale.action_orders") | |||
| result = action.read()[0] | |||
| result = action.sudo().read()[0] | |||
There was a problem hiding this comment.
@ps-tubtim Nope, you should use _for_xml_id() instead (Look after into code for examples)
There was a problem hiding this comment.
@rousseldenis Thank you for your suggestion. I already updated it.
ps-tubtim
force-pushed
the
15.0-fix-sale_order_revision
branch
from
64a368d
to
c8afe2d
Compare
ps-tubtim
force-pushed
the
15.0-fix-sale_order_revision
branch
from
c8afe2d
to
a71e252
Compare
ps-tubtim
changed the title
ps-tubtim
changed the title
|
@ps-tubtim I will fix pre-commit with #2617. Just rebase when merged |
rousseldenis
approved these changes
Jul 26, 2023
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6fc5c8c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error when another user clicks the smart button Prev. revision on sale.order view.