Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] sale_stock_prebook: Add process to prebook a sale order's stock #2624

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from

Conversation

mt-software-de
Copy link

@mt-software-de mt-software-de commented Jul 28, 2023

Add process to prebook/reserve a sale order's stock before confirming it.

Depends on
OCA/stock-logistics-warehouse#1807 NO NEEDED ANYMORE
OCA/wms#769 MERGED

@mt-software-de
Copy link
Author

cc @jbaudoux

@rousseldenis
Copy link
Contributor

@mt-software-de What's the difference with stock_reserve_sale ?

OCA/stock-logistics-warehouse#1788

@mt-software-de
Copy link
Author

mt-software-de commented Jul 29, 2023

@mt-software-de What's the difference with stock_reserve_sale ?

OCA/stock-logistics-warehouse#1788

Please read the comment of @jbaudoux OCA/stock-logistics-warehouse#1696 (comment)
This explains it very well.

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 2 times, most recently from 4d44c8f to 45daaa6 Compare October 30, 2023 11:15
@mt-software-de
Copy link
Author

OCA/wms#769 is needed for this PR.

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

jbaudoux commented Oct 30, 2023

OCA/wms#769 is needed for this PR.

Can you update this PR description with this?

@mt-software-de mt-software-de force-pushed the 14.0-add-sale_stock_prebook branch 4 times, most recently from 3574259 to 1b4c64a Compare November 10, 2023 00:27
@rafaelbn rafaelbn added this to the 14.0 milestone Dec 2, 2023
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested 👍🏼

In my opinion README with the USAGE section should be improved with all how to / step by step. In other case, less reviewer, less user adopting it. 😄 ❤️

@mt-software-de
Copy link
Author

This one is now ready to merge, i removed the dependency to stock_helper and included the very specific logic to stop the proc run, within the module itself.

Take moves into account when computing the previous promised qty
Keep date_priority of Confirmed sale.orders which were reserved before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants