Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] sale_blanket_order: add blanket order line form #2626

Merged
merged 1 commit into from
Aug 21, 2023
Merged

[14.0][IMP] sale_blanket_order: add blanket order line form #2626

merged 1 commit into from
Aug 21, 2023

Conversation

marcelsavegnago
Copy link
Member

No description provided.

@marcelsavegnago marcelsavegnago force-pushed the 14.0-imp-sale_blanket_order-add_blanket_order_line_form branch 3 times, most recently from 8a28403 to bb3f0b5 Compare July 31, 2023 20:57
@marcelsavegnago marcelsavegnago marked this pull request as draft July 31, 2023 20:58
@marcelsavegnago marcelsavegnago force-pushed the 14.0-imp-sale_blanket_order-add_blanket_order_line_form branch from bb3f0b5 to 5a7d784 Compare July 31, 2023 21:22
@marcelsavegnago marcelsavegnago force-pushed the 14.0-imp-sale_blanket_order-add_blanket_order_line_form branch from 5a7d784 to 86d4435 Compare August 1, 2023 12:27
@marcelsavegnago marcelsavegnago marked this pull request as ready for review August 1, 2023 12:28
@marcelsavegnago
Copy link
Member Author

cc @rvalyi @renatonlima @douglascstd

kaynnan
kaynnan approved these changes Aug 1, 2023
View reviewed changes
Copy link

@kaynnan kaynnan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM [FUNCIONAL TEST]

image

douglascstd
douglascstd approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@douglascstd douglascstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[FUNCTIONAL TEST] APPROVED
Original behaivoir:
image

Form View Implemented:
image

@marcelsavegnago marcelsavegnago mentioned this pull request Aug 1, 2023
Merged
augustodinizl
augustodinizl approved these changes Aug 1, 2023
View reviewed changes
Copy link

@augustodinizl augustodinizl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelsavegnago
Copy link
Member Author

ping @renatonlima @rvalyi @mileo

@dreispt
Copy link
Member

dreispt commented Aug 21, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2626-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ca01cdd into OCA:14.0 Aug 21, 2023
9 of 10 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9dc9287. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 14.0-imp-sale_blanket_order-add_blanket_order_line_form branch August 21, 2023 22:29
@marcelsavegnago
Copy link
Member Author

marcelsavegnago commented Aug 21, 2023 •
edited
Loading

@kaynnan or @rodrigonevest please port to 15.0 and 16.0. Thanks

@kaynnan kaynnan mentioned this pull request Aug 25, 2023
Closed
@kaynnan kaynnan mentioned this pull request May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaynnan kaynnan kaynnan approved these changes

@augustodinizl augustodinizl augustodinizl approved these changes

@douglascstd douglascstd douglascstd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcelsavegnago @dreispt @OCA-git-bot @douglascstd @augustodinizl @kaynnan