Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] sale_cancel_restrict #2933

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ADD] sale_cancel_restrict #2933

wants to merge 1 commit into from

Conversation

DavidJForgeFlow
Copy link
Contributor

When you try to cancel a sales order, if there is some delivery done or an invoice not cancelled will prevent the sales order from being cancelled.

@ForgeFlow @AaronHForgeFlow

@DavidJForgeFlow DavidJForgeFlow changed the title [16.0][ADD] sale_cancel_restrict [15.0][ADD] sale_cancel_restrict Jan 29, 2024
@DavidJForgeFlow
[ADD] sale_cancel_restrict
36e36e0 
When you try to cancel a sales order, if there is some delivery done or an invoice not cancelled will prevent the sales order from being cancelled.
AungKoKoLin1997
AungKoKoLin1997 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

AaronHForgeFlow
AaronHForgeFlow approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Feb 3, 2024

What if you conformed a delivery by mistake, made a return to correct it, having total delivered quantity zero.
Shouldn't this order be able to be cancelled?

@rousseldenis
Copy link
Contributor

@DavidJForgeFlow There is already this in v10 and migration PR for the invoice part : #2598

@rousseldenis
Copy link
Contributor

@DavidJForgeFlow Have you looked at #2598 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved question ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DavidJForgeFlow @OCA-git-bot @dreispt @rousseldenis @AaronHForgeFlow @AungKoKoLin1997