[17.0][MIG] sale_confirm_activities_mandatory: Migration to 17.0 #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankinmax
force-pushed
the
17.0-mig-sale_confirm_activities_mandatory
branch
5 times, most recently
from
7297daa
to
bcd6a5f
Compare
SilvioC2C
suggested changes
Mar 22, 2024
sale_confirm_activities_mandatory/models/mail_activity_mixin.py
Outdated
Show resolved
Hide resolved
|
@SilvioC2C thanks for your review |
yankinmax
force-pushed
the
17.0-mig-sale_confirm_activities_mandatory
branch
from
bcd6a5f
to
48293b8
Compare
yankinmax
force-pushed
the
17.0-mig-sale_confirm_activities_mandatory
branch
from
48293b8
to
5d9499e
Compare
Camille0907
approved these changes
Mar 25, 2024
Comment on lines
+96
to
+97
| # SO must have 3 activities (the default one and the 2 validations ones | ||
| self.assertEqual(2, len(self.sale_order.activity_ids)) |
| ].action_done_schedule_next() | ||
| # no activities left on SO | ||
| self.assertEqual(0, len(self.sale_order.activity_ids)) | ||
| # user_not_validator should not be able to confirm sale order |
|
/ocabot migration sale_confirm_activities_mandatory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of:
Depends on: