[ADD] sale_stock_partner_warehouse #3044
Conversation
santostelmo
force-pushed
the
16.0-add-sale_stock_partner_warehouse
branch
from
e40e34c
to
d3e90d7
Compare
| ], | ||
| "depends": [ | ||
| "sale_stock", | ||
| "delivery", |
There was a problem hiding this comment.
why delivery?
If it's only for the view, you can simply use <group name="sale" position="inside">.
There was a problem hiding this comment.
I removed dependency
| _inherit = "sale.order" | ||
|
|
||
| warehouse_id = fields.Many2one( | ||
| compute="_compute_warehouse_id", store=True, precompute=True |
There was a problem hiding this comment.
To compute the value before the record creation
There was a problem hiding this comment.
@santostelmo As warehouse_id is defined in sale_stock, you don't need to repeat the properties. Just override _compute_warehouse_id()
There was a problem hiding this comment.
@santostelmo I know, I mean... why do you need that? I guess it's because the wh is supposed to be already there on create.
If there's a motivation, it's worth to add a comment there.
santostelmo
force-pushed
the
16.0-add-sale_stock_partner_warehouse
branch
from
d3e90d7
to
6932b67
Compare
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| sale_warehouse_id = fields.Many2one("stock.warehouse", string="Sale Warehouse") |
There was a problem hiding this comment.
IMHO, this should be company dependent.
There was a problem hiding this comment.
I agree. The company of the partner, if defined must be consistent with the one set in the warehouse
There was a problem hiding this comment.
Actually after thinking about that I think we don't want to have sale_warehouse_id dependent of the company. We want to be able to select any warehouse from active companies.
With that option a Sale can be created in a company A and Delivered from the Warehouse of the company B
| compute="_compute_warehouse_id", store=True, precompute=True | ||
| ) | ||
|
|
||
| @api.depends("user_id", "company_id", "partner_id") |
There was a problem hiding this comment.
You don't need to repeat user_id and company_id. Odoo will append partner_id to depends list
There was a problem hiding this comment.
Thank you I updated that
|
@simahawk Could you update your review ? |
santostelmo
force-pushed
the
16.0-add-sale_stock_partner_warehouse
branch
from
6932b67
to
4d0cea5
Compare
| _inherit = "sale.order" | ||
|
|
||
| warehouse_id = fields.Many2one( | ||
| compute="_compute_warehouse_id", store=True, precompute=True |
There was a problem hiding this comment.
@santostelmo I know, I mean... why do you need that? I guess it's because the wh is supposed to be already there on create.
If there's a motivation, it's worth to add a comment there.
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1d4ae62. Thanks a lot for contributing to OCA. ❤️ |
Description
Allow to choose by default a warehouse on SO based on a Partner parameter.
If the warehouse parameter is completed, then this value would be the default one on the sale.
If empty, then the warehouse on sale would be the standard default warehouse.