Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] new module 'product_margin_classification'; #316

Merged
merged 4 commits into from
Nov 2, 2016

Conversation

legalsylvain
Copy link
Contributor

Add new module 'product_margin_classification'

a margin classification is a group of products with similar margin computation.

This module allow to change massively sale price, based on cost price and margin and to see incorrect margin.
Contrary to default Odoo functionnality (Sale Price List based on Cost Price), this allow users (salers) to change sale price in another moment than when cost price is changed. (Cost price is generaly changed when picking is received or delivered (CUMP / FIFO / LIFO methods) or when purchasers see that purchase prices have changed (manual method)).

This module is also usefull to avoid to impact sale price if purchase price changes temporaly. (temporary discount)

see readme file for complete description.

margin_classification_form

Reviews welcome.

Kind regards.

@legalsylvain legalsylvain added this to the 8.0 milestone Jul 11, 2016
A margin classification has a margin field (and fields to manage rounding method, like Pricelist Item model).

If product has a margin classification defined, an extra field
'Theoritical Price' is displayed, based on the Margin and the Cost Price.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%s/heoritical/heoretical

@legalsylvain
Copy link
Contributor Author

(runbot error not related).

@hparfr
Copy link

hparfr commented Jul 11, 2016

👍

[ADD] fr translation;
[FIX] OCA convention;
@legalsylvain
Copy link
Contributor Author

Travis is failing and log are pretty weird.
@gurneyalex any idea ?

@gurneyalex
Copy link
Member

@legalsylvain this is a question for @moylop260 : pylint-odoo crashed. Reported as OCA/pylint-odoo#60

@gurneyalex
Copy link
Member

is it MS Comic Sans I see on the icon?

@moylop260
Copy link
Contributor

@legalsylvain
Could you review my last comment: OCA/pylint-odoo#60 (comment)?

@legalsylvain
Copy link
Contributor Author

@gurneyalex : indeed, this is MS comic Sans.

@gurneyalex
Copy link
Member

@legalsylvain I'm not sure we should let MS Comic Sans creep in the OCA code base 😸
but I won't fight against it either.

LGTM 👍

@legalsylvain
Copy link
Contributor Author

Thanks for your review. 2 Thumbs up. -> Merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants