Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][IMP] sale_order_type: Remove required fields to make it more flexible #368

Merged
merged 1 commit into from
Dec 20, 2016
Merged

[9.0][IMP] sale_order_type: Remove required fields to make it more flexible #368

merged 1 commit into from
Dec 20, 2016

Conversation

carlosdauden
Copy link
Contributor

Remove those required fields does not affect to actual use and improves more flexibility.

@Tecnativa

@carlosdauden
Copy link
Contributor Author

Unrelated runbot error:

Traceback (most recent call last):
File "/entrypoint_image", line 134, in
docker_entrypoint()
File "/entrypoint_image", line 126, in docker_entrypoint
open(fname_coveralls, 'w').writelines(coveralls_lines)
IOError: [Errno 2] No such file or directory: '/openerp/addons/.coveralls.yml'
Working in /openerp/addons
Using repo odoo/odoo and addons path /openerp/addons,/root/odoo-9.0/addons
WARNING!
Nothing to test- exiting early.

pedrobaeza
pedrobaeza reviewed Dec 4, 2016
View reviewed changes
sale_order_type/models/sale_order_type.py
@@ -34,10 +34,10 @@ def default_picking_policy(self):
comodel_name='account.journal', string='Billing Journal',
domain=[('type', '=', 'sale')])
warehouse_id = fields.Many2one(
comodel_name='stock.warehouse', string='Warehouse', required=True)
comodel_name='stock.warehouse', string='Warehouse')
Copy link
Member

@pedrobaeza pedrobaeza Dec 4, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't remove this one, as the company is determined as a related field of this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looking at the multi-company rule, company_id=False is allowed as a type seen by any company, so it's good to leave it empty and create a multi-company type.

@eLBati eLBati merged commit 8edc106 into OCA:9.0 Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosdauden @eLBati @pedrobaeza