Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] connector_search_engine: not possible to edit index lines #140

Merged
merged 1 commit into from
May 22, 2023

Conversation

acsonefho
Copy link
Contributor

Tree view (into backend) who displays indexes remove backend_id (invisible field) so not possible to edit a line (to update the exporter_id for example). Removing this no-visible field solve the issue.

@xavier-bouquiaux
Copy link
Contributor

LGTM

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 21, 2023
@acsonefho
Copy link
Contributor Author

@OCA/search-engine-maintainers Can you review and merge please? Easy quick and old fix.

@HviorForgeFlow HviorForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels May 22, 2023
@simahawk
Copy link
Contributor

@acsonefho Seems legit. One small request: can you please rewrite the commit msg?
The explanation is not meant to stay in the short msg itself, it goes into the commit description. Our ref: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

Example that you can copy / paste if you like:

[FIX] connector_search_engine: fix se.index edit

Since the field was hidden it was not possible to edit a line (to update the exporter for example).
Removing this no-visible field solves the issue.

@simahawk
Copy link
Contributor

@acsonefho Seems legit. One small request: can you please rewrite the commit msg? The explanation is not meant to stay in the short msg itself, it goes into the commit description. Our ref: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

Example that you can copy / paste if you like:

[FIX] connector_search_engine: fix se.index edit

Since the field was hidden it was not possible to edit a line (to update the exporter for example).
Removing this no-visible field solves the issue.

Note: I'm not blocking, if you are in a rush we can merge as-is. Still, if you have time please do it 🙏

Since the field was hidden it was not possible to edit a line (to update the exporter for example).
Removing this no-visible field solves the issue.
@acsonefho acsonefho force-pushed the 14.0-fix_index_backend_view_editable branch from 254b9e9 to b9c4d44 Compare May 22, 2023 06:47
@acsonefho
Copy link
Contributor Author

@simahawk Thank you for your feedback. I edit the commit :)

@simahawk
Copy link
Contributor

/ocabot merge patch

@acsonefho
Copy link
Contributor Author

/ocabot merge patch

@simahawk I think the command doesn't work

@HviorForgeFlow
Copy link
Member

Sometimes ocabot has this behavior, from my experience it will work at some point during the day 😄

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-140-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 22, 2023
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-140-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b10eaf4 into OCA:14.0 May 22, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 44c6341. Thanks a lot for contributing to OCA. ❤️

@acsonefho acsonefho deleted the 14.0-fix_index_backend_view_editable branch May 22, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants