-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] connector_search_engine: not possible to edit index lines #140
[FIX] connector_search_engine: not possible to edit index lines #140
Conversation
LGTM |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@OCA/search-engine-maintainers Can you review and merge please? Easy quick and old fix. |
@acsonefho Seems legit. One small request: can you please rewrite the commit msg? Example that you can copy / paste if you like:
|
Note: I'm not blocking, if you are in a rush we can merge as-is. Still, if you have time please do it 🙏 |
Since the field was hidden it was not possible to edit a line (to update the exporter for example). Removing this no-visible field solves the issue.
254b9e9
to
b9c4d44
Compare
@simahawk Thank you for your feedback. I edit the commit :) |
/ocabot merge patch |
@simahawk I think the command doesn't work |
Sometimes ocabot has this behavior, from my experience it will work at some point during the day 😄 |
/ocabot merge patch |
On my way to merge this fine PR! |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 44c6341. Thanks a lot for contributing to OCA. ❤️ |
Tree view (into backend) who displays indexes remove
backend_id
(invisible field) so not possible to edit a line (to update theexporter_id
for example). Removing this no-visible field solve the issue.