[MIG] auth_saml: Migrate to 13.0 #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisg123v
force-pushed
the
13.0-mig_auth_saml-luisg
branch
from
edb7ede
to
e477016
Compare
luisg123v
force-pushed
the
13.0-mig_auth_saml-luisg
branch
4 times, most recently
from
4c2211f
to
396f904
Compare
[IMP] Cleanup
[ADD] icon.png
The following line of code for 11.0: - https://github.com/odoo/odoo/blob/52d6f0e3ee90874fc93fec9cdff74ec71d3b991f/addons/auth_oauth/controllers/main.py#L69 is assigning the key "auth_link" for "list_providers" method. The following template is expecting this key: - https://github.com/odoo/odoo/blob/52d6f0e3ee90874fc93fec9cdff74ec71d3b991f/addons/auth_oauth/views/auth_oauth_templates.xml#L5 So, it raise a KeyError compiling "template_auth_oauth_providers_N" This change is fixing adding that expected key in order to avoid this KeyError
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-11.0/server-auth-11.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-11-0/server-auth-11-0-auth_saml/
[FIX] dependencies
add requirement on lasso
- Default behavior is now to allow password and SAML together. Otherwise, users could keep getting their passwords removed without warning. - General cleanup. - Remove relations to field `password_crypt` because in v12 the `password` field is always encrypted instead. Co-Authored-By: Alexandre Díaz <alexandre.diaz@tecnativa.com>
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-12.0/server-auth-12.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_saml/ auth_saml 12.0.1.0.1
luisg123v
force-pushed
the
13.0-mig_auth_saml-luisg
branch
from
396f904
to
fb7b63c
Compare
luisg123v
force-pushed
the
13.0-mig_auth_saml-luisg
branch
from
fb7b63c
to
fdf26d5
Compare
Merged
|
Hi @theangryangel, They do pretty much the same. I wasn't aware of that PR, it was not announced on #136. Please whenever migrating a module, firstly announce it in the migration issue to don't duplicate work like here. Are the PR in active development? If so, I'd say you finish it up, since you started it first. You may copy tests I've started and I may give you technical review. I'd also recommend scuashing all new commits and give authorship using Regards, |
|
Superseded by #214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.