-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] users_ldap_groups #46
Conversation
@hbrunn if you don't mind, please take a look |
Frankly speaking, not much code left :| |
2e774b9
to
7e6f7d9
Compare
@pedrobaeza if you don't mind, I'll bump this to your attention |
Well, I can't be very helpful here as I don't use this module and don't know about this area. What I can say is about the guidelines, as this module contains plurals, being dragged since long, but I won't force to change it if contributors don't want. |
Frankly speaking, I'm thinking of making a bit revised (an more UX-friendly) one as an alternative |
Looking at the description, |
It may, and actually they do share some code. I think that's up to reviewers if to keep modules lean-and-mean or to make complex ones. Why |
@hbrunn you were the original author of this. What do you think? |
I think it's great that @alexey-pelykh does all the efforts, thanks for that. Group stuff is very different from attributes like whatever is not a group, so I think this surely merits its own module. |
Can we rename this at least to |
Indeed was issue with the code and with tests |
ee32d69
to
8e01e59
Compare
Decided to keep the original behaviour, thus changed the PR |
cdd1412
to
1ae48ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change Otherwise LGTM
This PR has the |
1ae48ae
to
f09a8a5
Compare
Hey @alexey-pelykh, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
@alexey-pelykh thanks a lot for this. I would advise you to ping people as little as possible, we're all doing our best in reviews. In the best case, your ping doesn't create more time for people and is basically a no-op, in the worst case it creates noise. |
No description provided.