Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15.0 mig users_ldap_mail #488

Closed
wants to merge 19 commits into from
Closed

15.0 mig users_ldap_mail #488

wants to merge 19 commits into from

Conversation

katyukha
Copy link

No description provided.

dreispt and others added 18 commits July 17, 2021 17:23
@dreispt @primes2h
ADD Module to use email from LDAP records
e566ec9 
ADD defsult and sugegsted values; auto-install
@dreispt @primes2h
Port users_ldap_mail to v8
bb51648 
Fix PEP8
@sbidoul @primes2h
Fix 9.0 version
7dce400
@StephanRozendaal @primes2h
10.0 Migrate users_ldap_mail module (OCA#651)
5b087d5 
* [ADD] Add README.rst to users_ldap_mail

* [MIG] Migrate users_ldap_mail to 10.0

* [FIX] Fixes in code style in module  users_ldap_mail

Changes in models/users_ldap_mail include:
 - remove unused imports
 - indentation of too long lines

* [FIX] users_ldap_mail: Fix copyright notice

* [FIX] users_ldap_mail: set UTF-8 encoding

users_ldap_mail/models/__init__.py should be UTF-8 encoded

* [FIX] users_ldap_mail: remove size argument from Char fields

* [FIX] users_ldap_mail: return value can be combined in one line

* [FIX] Update read me

Fixes included:
 - Make module name human readable
 - Instead of numbering steps, use #
 - Update broken link
@etobella @primes2h
[MIG] users_ldap_mail
d07a90b
@primes2h
[10.0][FIX] users_ldap_mail: Provide defaults to attributes properly
8a64d46 
Forward-port OCA/server-tools#1405.
@Tardo @primes2h
[MIG] users_ldap_mail: Migration to 12.0
399d626
@joao-p-marques @primes2h
[IMP] users_ldap_mail: black, isort, prettier
cd54691
@joao-p-marques @primes2h
[MIG] users_ldap_mail: Migration to 13.0
4758cee
@oca-travis @primes2h
[UPD] Update users_ldap_mail.pot
9a02a2f 
[UPD] README.rst
@sbidoul @primes2h
Apply dotfiles
6a430f7
@primes2h
[MIG] users_ldap_mail: Migration to 14.0
08cbcec
@primes2h
[FIX] string typo and license
46e7be5
@oca-travis
[UPD] Update users_ldap_mail.pot
1db8e18
@OCA-git-bot
[IMP] update dotfiles [ci skip]
113dbf6
@flotho
FIX: force the cast in string in case of the Active directory is prov…
9fcb473 
…inding byte-code strings
@OCA-git-bot
users_ldap_mail 14.0.1.0.1
8c20184
@katyukha
[MIG][15.0] Migrate users_ldap_mail to 15.0
781e67a
@katyukha katyukha force-pushed the 15.0-mig-users-ldap-mail branch 2 times, most recently from c21f668 to ece8dcf Compare February 24, 2023 18:12
@katyukha
Copy link
Author

Hi @joao-p-marques,

Please, review this migration of users_ldap_mail addon to Odoo 15.

Thanks a lot)

albig
albig approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@albig albig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Odoo 15.0 as expected. Thank you for migration!

@albig
Copy link
Contributor

albig commented May 4, 2023

@joao-p-marques could you please review this PR? For me, it seems to work.

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 3, 2023
@etobella
Copy link
Member

etobella commented Sep 4, 2023

Something is weird with your commit history, If you access any commit (except yours) Data is empty. Can you restore the real history?

Also, you should only have 2 commits on a migration, the first one for black and lint and the second one for the migration.

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@dreispt dreispt changed the title 15.0 mig users ldap mail 15.0 mig users_ldap_mail Sep 4, 2023
@katyukha
Copy link
Author

katyukha commented Sep 4, 2023

Thanks, i will check it.

As i remember, i had used git filter-branch or git subtree command to fetch from history commits related to this module.

I will try redo it as in provided instruction.

Thanks)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 10, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 14, 2024
@bosd
Copy link
Contributor

bosd commented Jan 14, 2024

Can you please rebase?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 21, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@github-actions github-actions bot closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albig albig albig approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.