[12.0][MIG] auth_api_key from 10 to 12 #56

sbidoul · 2018-11-20T17:00:05Z

Migration of #51

TODO

change license to LGPL pending confirmation on [10.0] add auth_api_key #51

…custom one from shopinvader

Get rid of keychain dependency

lmignon · 2018-11-20T17:26:36Z

@sbidoul the last commits of #51 are missing and should fix travis

[FIX] add oca dependencies 1aa57d8
[FIX] Travis: add [running_env] section into openerp_serverrc: b55f684

lmignon · 2018-11-20T17:28:37Z

@sbidoul The name of the migrated module is auth_api_key not server_auth 😏

sbidoul · 2018-11-21T10:43:18Z

🍏

RobinetDenisAcsone

Seem good to me, just a small request

RobinetDenisAcsone · 2018-11-27T12:25:44Z

auth_api_key/models/auth_api_key.py

+                    continue
+
+                login_name = serv_config.get(section, "user")
+                uid = self.env["res.users"].search(


@sbidoul Is it possible to modify to search also the active=False users?

Note: The suggestion below is 83 char (too long), but suggestion on multi lines isn't possible

Suggested change

uid = self.env["res.users"].search(

uid = self.env["res.users"].with_context(active_test=False).search(

I'm not sure. I kind of remember people (was it @guewen?) saying running code under an inactive user was a bad idea, but I'm don't remember why.

@sbidoul I do not know on further versions but at least on V10.0 I have absolutely no troubles while running code with an inactive technical user....

@lmignon any opinion on this?

@sbidoul IMO we must keep the possibility to select an inactive user (it's under the responsibility of the integrator/administrator to select the most appropriate one active or inactive). We must keep in mind that (at least in odoo < 12) active users are paid users. That's why we use inactive users in such use cases.

I'm not sure. I kind of remember people (was it @guewen?) saying running code under an inactive user was a bad idea, but I'm don't remember why.

The problem with inactive users is that they will be removed from the group that they are in as soon as you edit the user list on an ir.group. The m2m widget for users on the group will not include them - as they are inactive, so if you changes the list, it will remove it.

I do not know on further versions but at least on V10.0 I have absolutely no troubles while running code with an inactive technical user....

Neither on other versions, until you edit the other users on a group and wonder why suddenly it doesn't work anymore ;)

gurneyalex · 2018-12-11T18:58:25Z

@sbidoul #51 is merged, was there anything you needed to pick from that PR before this one gets merged?

ap-wtioit · 2018-12-12T11:14:49Z

@gurneyalex this addon depends on server_environment which is not yet migrated to 12.0 (or 11.0) in https://github.com/OCA/server-tools

i could add the code suggestion from our private repo where we removed the dependency if that is ok

sbidoul · 2019-01-25T08:37:01Z

@ap-wtioit server_environment is merged in https://github.com/OCA/server-env

Co-Authored-By: qgroulard <43472442+qgroulard@users.noreply.github.com>

sbidoul · 2019-01-25T18:02:00Z

@gurneyalex I've cherry-picked the consteq commit of @ap-wtioit, so this is now ready to merge.

lmignon · 2019-02-13T10:45:58Z

Is everyone agreed to merge?

ychirino · 2019-02-13T20:39:02Z

Blunt question: How many sessions are created by this implementation for 1.000.000 requests during a time span of 7 days? - I wonder if it's 1.000.000 or if I'm missing something...

sbidoul · 2019-02-13T21:23:56Z

@ychirino In my experience, there is no sessions issue, as long as the client handles cookies properly. For python clients, using request.Session() is easy enough.

It might be worth mentioning in the readme of auth_api_key, though.

ychirino · 2019-02-13T21:31:52Z

@sbidoul Yeah, I wondered. Thanks. My main concern is a bearer token approach for an external API client. I can't guarantee in no way that it would stick to this pretty please recommendation. For more details see this comment.

ychirino · 2019-02-13T21:44:08Z

Maybe a k/v map in memory assigning each token to a session? It's not a canonical solution but would reduce that problem by some orders of magnitude.
Assuming that workers power cycle every hour (7d * 24h * 5w * 10apikeys) 8.400 sessions vs 1.000.000 c.p.

sbidoul · 2019-02-13T21:46:18Z

@ychirino multi-db is not really supported by this module at the moment.

Regarding the session, I'm not sure what problem you want to solve. It's easy to ask clients to return cookies.

ychirino · 2019-02-13T21:57:33Z

@sbidoul There is a POC implementation of a bearer token here.

The problem depends on what "easy" in "easy to ask clients to return cookies" actually means. On a publicized API It assumes cooperative clients. I'm not sure that's a valid assumption.

Or did I miss something here?

sbidoul · 2019-02-14T08:06:20Z

@ychirino api keys and bearer tokens are for different use cases. api keys are meant for cooperating clients indeed. If you need bearer tokens that's for another module.

BTW, this is a migration PR, so please do not pollute it with unrelated comments.

lmignon · 2019-02-14T08:23:15Z

auth_api_key/README.rst

+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png


I suppose that the licence badge will be fixed once the PR will be merged and the readme re generated

ychirino · 2019-02-14T14:09:37Z

@lmignon Thanks for the clarification indeed, is a more extensive topic.

lmignon and others added 15 commits November 20, 2018 16:43

New generic module du define REST services

9e9a0da

auth_api_key: New module to provide authentication by api_key

6ad0403

auth_api_key: Remove useless code

ab83ecc

Update the auth_api_key for keychan 10.0.2 (renamed method)

a78464b

Fix the authentification method and show the user_id on the form

c5a7797

refactor code in order to use generic code from base_rest instead of …

c754c00

…custom one from shopinvader

fix wrong name in selection box

ffae44e

Since keychain 10.0.2.0.1 there is a default validation method

d70ff8e

Keychain removed

9621ded

Get rid of keychain dependency

Update Readme with more details

9745204

Quick fix CONFIGURE.rst

167b0da

Developmet status: Beta

6089299

[FIX] auth_api_key: fix api and flake8

1ba402b

[ADD] setup.py

be7419d

[MIG] server_auth from 10 to 12

5fa243d

sbidoul added the work in progress label Nov 20, 2018

sbidoul added this to the 12.0 milestone Nov 20, 2018

OCA-git-bot mentioned this pull request Nov 20, 2018

Migration to version 12.0 #38

Closed

19 tasks

auth_api_key: add description to model

17ec5a5

sbidoul changed the title ~~[12.0][MIG] server_auth from 10 to 12~~ [12.0][MIG] auth_api_key from 10 to 12 Nov 21, 2018

lmignon and others added 2 commits November 21, 2018 11:00

[FIX] Travis: add [running_env] section into openerp_serverrc

e263b51

[FIX] add oca_dependencies.txt

8edf0bc

sbidoul force-pushed the 12.0-mig-auth_api_key branch from 6da46a7 to 8edf0bc Compare November 21, 2018 10:00

[CHG] auth_api_key is LGPL

a1ce7b9

lmignon approved these changes Nov 21, 2018

View reviewed changes

RobinetDenisAcsone mentioned this pull request Nov 26, 2018

[11.0][MIG] auth_api_key from 12 to 11 #60

Closed

RobinetDenisAcsone reviewed Nov 27, 2018

View reviewed changes

gurneyalex approved these changes Dec 11, 2018

View reviewed changes

OCA-git-bot added the approved label Dec 11, 2018

Use consteq to compare keys

4b1b28d

Co-Authored-By: qgroulard <43472442+qgroulard@users.noreply.github.com>

lmignon mentioned this pull request Feb 13, 2019

Support for authentication OCA/rest-framework#12

Closed

lmignon removed the work in progress label Feb 14, 2019

lmignon reviewed Feb 14, 2019

View reviewed changes

lmignon merged commit 80605d5 into OCA:12.0 Feb 14, 2019

lmignon deleted the 12.0-mig-auth_api_key branch February 14, 2019 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] auth_api_key from 10 to 12 #56

[12.0][MIG] auth_api_key from 10 to 12 #56

sbidoul commented Nov 20, 2018 •

edited

Loading

lmignon commented Nov 20, 2018

lmignon commented Nov 20, 2018

sbidoul commented Nov 21, 2018

RobinetDenisAcsone left a comment

RobinetDenisAcsone Nov 27, 2018

sbidoul Nov 27, 2018

Cedric-Pigeon Nov 27, 2018

sbidoul Nov 27, 2018

lmignon Nov 27, 2018

guewen Dec 12, 2018 •

edited

Loading

guewen Dec 12, 2018

gurneyalex commented Dec 11, 2018

ap-wtioit commented Dec 12, 2018 •

edited

Loading

sbidoul commented Jan 25, 2019

sbidoul commented Jan 25, 2019

lmignon commented Feb 13, 2019

ychirino commented Feb 13, 2019

sbidoul commented Feb 13, 2019

ychirino commented Feb 13, 2019

ychirino commented Feb 13, 2019 •

edited

Loading

sbidoul commented Feb 13, 2019

ychirino commented Feb 13, 2019 •

edited

Loading

sbidoul commented Feb 14, 2019

lmignon Feb 14, 2019

sbidoul Feb 14, 2019

ychirino commented Feb 14, 2019 •

edited

Loading

	uid = self.env["res.users"].search(
	uid = self.env["res.users"].with_context(active_test=False).search(

[12.0][MIG] auth_api_key from 10 to 12 #56

[12.0][MIG] auth_api_key from 10 to 12 #56

Conversation

sbidoul commented Nov 20, 2018 • edited Loading

lmignon commented Nov 20, 2018

lmignon commented Nov 20, 2018

sbidoul commented Nov 21, 2018

RobinetDenisAcsone left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guewen Dec 12, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gurneyalex commented Dec 11, 2018

ap-wtioit commented Dec 12, 2018 • edited Loading

sbidoul commented Jan 25, 2019

sbidoul commented Jan 25, 2019

lmignon commented Feb 13, 2019

ychirino commented Feb 13, 2019

sbidoul commented Feb 13, 2019

ychirino commented Feb 13, 2019

ychirino commented Feb 13, 2019 • edited Loading

sbidoul commented Feb 13, 2019

ychirino commented Feb 13, 2019 • edited Loading

sbidoul commented Feb 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ychirino commented Feb 14, 2019 • edited Loading

sbidoul commented Nov 20, 2018 •

edited

Loading

guewen Dec 12, 2018 •

edited

Loading

ap-wtioit commented Dec 12, 2018 •

edited

Loading

ychirino commented Feb 13, 2019 •

edited

Loading

ychirino commented Feb 13, 2019 •

edited

Loading

ychirino commented Feb 14, 2019 •

edited

Loading