[DRAFT][15.0][IMP] auth_password_pwned: check passwords against haveibeenpwned.com #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
amh-mw
suggested changes
Sep 11, 2024
| request.env["ir.config_parameter"] | ||
| .sudo() | ||
| .get_param("auth_signup.reset_password") | ||
| == "True" |
There was a problem hiding this comment.
Seems aberrant to check for a string value to exactly equal True, but that does seem to match what the auth_signup module does.
|
|
||
| super()._set_password() | ||
|
|
||
| def _passswordshavebeenpwned(self, passwords): |
github-actions
bot
removed
the
stale
ap-wtioit
force-pushed
the
15.0-imp_auth_password_pwned
branch
2 times, most recently
from
e8dd4be
to
1089bdb
Compare
ap-wtioit
force-pushed
the
15.0-imp_auth_password_pwned
branch
from
1089bdb
to
7486e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a module that checks password hashes against the haveibeenpwned.com API to make sure publicly known passwords can not be set in Odoo and not used to login anymore. The user is forced to use password reset upon login if it is enabled, an email is sent to him (if auth_signup is installed) or he has to contact an admin to ensure a safe password change.
This is still work in progress. Feedback welcome.
Planned tasks (next week):
Further reading: