Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor in customized template and alter menu app location #3

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Refactor in customized template and alter menu app location #3

merged 2 commits into from
Apr 9, 2018

Conversation

aldo774
Copy link
Member

@aldo774 aldo774 commented Apr 6, 2018

This PR have two simple modifications in disable_odoo_online module to correct the following problems:

  • After install module, references from odoo.com continue inside preferences menu of user, because the template used to remove them (UserMenu) has other id(UserMenu.Actions):

2018-04-06 14-56-24

  • Only updates menu item in settings is hidden inside technical parameters menu, the app menu still visible in settings:

2018-04-06 14-58-49

@pedrobaeza
Copy link
Member

Please change module version number

@pedrobaeza
Copy link
Member

https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers

@aldo774 aldo774 force-pushed the 11.0-feature_ref_disable_odoo_online branch from fb0780d to d8c60f8 Compare April 6, 2018 18:39
rodrigets
rodrigets approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@rodrigets rodrigets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza pedrobaeza merged commit 60f6d66 into OCA:11.0 Apr 9, 2018
@mstuttgart mstuttgart deleted the 11.0-feature_ref_disable_odoo_online branch April 9, 2018 16:42
eLBati pushed a commit to eLBati/server-brand that referenced this pull request Oct 21, 2018
@aldo774 @eLBati
Refactor in customized template and alter menu app location (OCA#3)
6ba270a 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
eLBati pushed a commit to eLBati/server-brand that referenced this pull request Oct 30, 2018
@aldo774 @eLBati
Refactor in customized template and alter menu app location (OCA#3)
5d89eae 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
tarteo pushed a commit to tarteo/server-brand that referenced this pull request Dec 6, 2019
@aldo774 @tarteo
Refactor in customized template and alter menu app location (OCA#3)
646a5e7 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
tarteo pushed a commit to tarteo/server-brand that referenced this pull request Dec 6, 2019
@aldo774 @tarteo
Refactor in customized template and alter menu app location (OCA#3)
0b35bca 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
mileo pushed a commit to kmee/server-brand that referenced this pull request Mar 31, 2020
@aldo774 @mileo
Refactor in customized template and alter menu app location (OCA#3)
500fc2e 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
mileo pushed a commit to kmee/server-brand that referenced this pull request Mar 31, 2020
@aldo774 @mileo
Refactor in customized template and alter menu app location (OCA#3)
de9a3b5 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
dsolanki-initos pushed a commit to initOS/server-brand that referenced this pull request Oct 21, 2020
@aldo774 @dsolanki-initos
Refactor in customized template and alter menu app location (OCA#3)
cd0828f 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
dsolanki-initos pushed a commit to initOS/server-brand that referenced this pull request Dec 18, 2020
@aldo774 @dsolanki-initos
Refactor in customized template and alter menu app location (OCA#3)
8769064 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
vincent-hatakeyama pushed a commit to xcgd/server-brand that referenced this pull request Mar 14, 2022
@aldo774 @vincent-hatakeyama
Refactor in customized template and alter menu app location (OCA#3)
7a69815 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
remi-filament pushed a commit to lefilament/server-brand that referenced this pull request Feb 8, 2023
@aldo774 @remi-filament
Refactor in customized template and alter menu app location (OCA#3)
11901ac 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
remi-filament pushed a commit to lefilament/server-brand that referenced this pull request Feb 8, 2023
@aldo774 @remi-filament
Refactor in customized template and alter menu app location (OCA#3)
c4ffba1 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
remi-filament pushed a commit to lefilament/server-brand that referenced this pull request Feb 8, 2023
@aldo774 @remi-filament
Refactor in customized template and alter menu app location (OCA#3)
a6ec9ff 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
lojanet pushed a commit to lojanet/server-brand that referenced this pull request Nov 17, 2023
@aldo774 @lojanet
Refactor in customized template and alter menu app location (OCA#3)
f4f12e1 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
OCA-git-bot pushed a commit to lojanet/server-brand that referenced this pull request Jul 19, 2024
@aldo774 @OCA-git-bot
Refactor in customized template and alter menu app location (OCA#3)
b959453 
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstuttgart mstuttgart mstuttgart approved these changes

@rodrigets rodrigets rodrigets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aldo774 @pedrobaeza @mstuttgart @rodrigets