Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] server_environment: Migration to 17.0 #168

Merged
merged 71 commits into from
Jan 8, 2024

Conversation

moitabenfdz
Copy link
Contributor

No description provided.

jgrandguillaume and others added 30 commits November 13, 2023 08:27
(lp:c2c-addons/6.1  rev 11)
(lp:c2c-addons/6.1  rev 28.1.1)
…t is the blessed target.

(lp:c2c-addons/6.1  rev 40.2.1)
(lp:c2c-addons/6.1  rev 45.1.4)
…TK client, because for 6.1 the web client is the blessed target.

(lp:c2c-addons/6.1  rev 116)
This fixes OCA/server-tools#125 because in some Ubuntu systems
lsb_release outputs to stderr as well as stdout. This message will be
printed to console, not logged nor shown among server infomation. That
way the message is lost and only pollutes unit tests output.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
* [IMP] load server environment options from odoo rcfile

This allows delivering the code with default configuration options for
all environments in the server_environment_file module, but letting
the administrator override some configuration entries in the regular
odoo configuration file.

* server_environment_file: update README
To trigger rebuild following change in setup.py
@moitabenfdz moitabenfdz marked this pull request as ready for review November 13, 2023 08:38
@gurneyalex
Copy link
Member

/ocabot migration 17.0

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 14, 2023
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-168-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 14, 2023
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-168-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Hi, @gurneyalex it should be:

/ocabot migration server_environment

And I have stopped the merge, because the PR contains a .deb inside.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove .deb file

@pedrobaeza pedrobaeza changed the title [17.0] [MIG] server environment [17.0][MIG] server_environment: Migration to 17.0 Nov 14, 2023
@pedrobaeza pedrobaeza dismissed their stale review November 14, 2023 13:16

.deb file removed, so no blocking formal point, but nothing to say about the module itself, except IMO this shouldn't be done by modules, but on the deployment stack.

@rven
Copy link

rven commented Nov 14, 2023

@pedrobaeza The .deb file is still in the history, maybe better to remove it from the initial commit also?

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-168-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9c834bf into OCA:17.0 Jan 8, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b37b684. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.