[12.0][MIG] server environment ir config parameter #1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values This is much more robust that raising an error, and let modules load ir.config_parameter from xml data files, while still enforcing values from the config files.
Odoo loads modules that contain static directory, so it wanted to load server_environment_files but it does not exist
Without this sudo get_param would fail when the first user reading a parameter that has changed in the configuration file does not have write access to system parameters.
acsonefho
suggested changes
Oct 2, 2018
|
|
||
| @api.model | ||
| def get_param(self, key, default=False): | ||
| value = super(IrConfigParameter, self).get_param(key, default=None) |
There was a problem hiding this comment.
In Python 3 you can let the super() empty:
value = super().get_param(key, default=None)
It's certainly not an issue (about Python) but it's not necessary.
| if serv_config.has_option(SECTION, key): | ||
| # enforce value from config file | ||
| vals = dict(vals, value=serv_config.get(SECTION, key)) | ||
| return super(IrConfigParameter, self).create(vals) |
| newvals = dict(vals, value=serv_config.get(SECTION, key)) | ||
| else: | ||
| newvals = vals | ||
| super(IrConfigParameter, rec).write(newvals) |
There was a problem hiding this comment.
But here you have to keep it because you use rec and not self.
| class TestEnv(common.TransactionCase): | ||
|
|
||
| def setUp(self): | ||
| super(TestEnv, self).setUp() |
sbidoul
requested changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1368