-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] attachment_unindex_content: Disable the indexation of files #1713
[ADD] attachment_unindex_content: Disable the indexation of files #1713
Conversation
Hey @ebirbe, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Hi @moylop260, @ebirbe, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Isn't the indexation done by |
Hello @pedrobaeza the indexation is being called directly from the base module. It will occur even if we do not install This is a query over a database without The Adittionally, there will be cases were you will want to have this feature of no indexation, but without uninstalling another modules that depends on So, this module disables indexation directly from the base, and without having to lose other functionalities. |
Thanks for the explanations. I think they are very interesting to be added to the README as well. |
This module is intended to disable the indexation of data on the ir.attachment model. Attachment model has a field called 'index_content' where the content of the attachment is read and stored directly in the database. This field is useful in order to search content of a file. But most of cases it is not used, so, you can install this module in order to: - **Avoid Duplicating Data:** Because indexation extracts text content from files and put it on the database in order it could be searched, but this implies you have the file data in your `filestore` directory, and also part (or sometimes all) of that data in your database too. - **Improve Performance:** Since not all indexed files are plain text, they require extra process to read them. Maybe you could try to uninstall modules like `document` in order to disable its indexation features, but you could face the uninstallation of other modules that could be useful for you (e.g, `hr_recruitment` depends on that). But even if you don't have `document` installed, you'd still have plain text content indexation by default. Using this module you will not require to uninstall any module to disable the attachment content indexation, because we directly disable it at `ir.attachment` base.
fc1329d
to
0c2c386
Compare
Thank you, I've updated the documentation. |
@pedrobaeza |
Thanks for review @guewen and @pedrobaeza /ocabot merge Since that it has the |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at e02d8d2. Thanks a lot for contributing to OCA. ❤️ |
This module is intended to disable the indexation of data on the ir.attachment model.
Attachment model has a field called 'index_content' where the content of the attachment is read and stored directly in the database. This field is useful in order to search content of a file. But most of cases it is not used, so, you can install this module in order to:
filestore
directory, and also part (or sometimes all) of that data in your database too.Maybe you could try to uninstall modules like
document
in order to disable its indexation features, but you could face the uninstallation of other modules that could be useful for you (e.g, hr_recruitment` depends on that).But even if you don't have
document
installed, you'd still have plain text content indexation by default.Using this module you will not require to uninstall any module to disable the attachment content indexation, because we directly disable it at
ir.attachment
base./cc @moylop260