[master] Tighten type check in domain #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i tested the patch and it solve the problem. Thanks |
|
a |
|
Here you have ;) 👍 (code review) |
|
👍 |
|
👍 (code review) |
|
Rebased |
| @@ -32,7 +32,7 @@ def search( | |||
| model_domain = [] | |||
| for domain in args: | |||
| if domain[0] == 'model_id' and domain[2]\ | |||
There was a problem hiding this comment.
@bwrsandman I think you should also remove the and domain[2] which is useless (and confusing) after the change below, as an empty string will not cause a problem. You may want to change it to and len(domain) == 3 which will avoid an IndexError when confronted with a bad formed domain, and which maybe was the original intent, but I would not do this as this will most certainly crash a couple of calls further down in the stack.
-> needs fixing
|
@gurneyalex done |
Fixes OCA#15 Check that `domain[2]` is `str` because in some cases it's an `int` and `list` operations don't work on `int`s.
|
@bwrsandman OK, I'll merge this and port the merge to 7.0 too (instead of #16) |
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Feb 26, 2017
[MIG] web_easy_switch_company
Garamotte
pushed a commit
to subteno-it/server-tools
that referenced
this pull request
Jul 12, 2017
base_report_to_printer: missing security
modoolar-bot
pushed a commit
to modoolar/oca-server-tools
that referenced
this pull request
Jan 14, 2022
[12.0][MIG] server environment from 11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Check that
domain[2]isstrbecause in some cases it's anintandlistoperations don't work on
ints.