Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][FIX] auditlog: Allow passing a chunk size for autovacuum #2335

Merged
merged 1 commit into from
May 25, 2022

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented May 10, 2022

this allows administrators to fine tune the amount of records to delete in one run of the autovacuum.

I also think we can get away with not recomputing after deletion, as we delete all relevant records eventually.

I'll be happy to cherry pick this to 13, 14, 15 when merged

@hbrunn hbrunn force-pushed the 12.0-auditlog-autovacuum-in-chunks branch from eff6318 to bb06915 Compare May 10, 2022 11:34
@hbrunn
Copy link
Member Author

hbrunn commented May 10, 2022

runboat build fixed in #2336

@hbrunn hbrunn added this to the 12.0 milestone May 10, 2022
@hbrunn hbrunn changed the title [FIX] auditlog: Allow passing a chunk size for autovacuum [12.0][FIX] auditlog: Allow passing a chunk size for autovacuum May 10, 2022
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@hbrunn hbrunn force-pushed the 12.0-auditlog-autovacuum-in-chunks branch from bb06915 to d4f8eb3 Compare May 11, 2022 07:21
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kanda999
Copy link

LGTM 👍

@StefanRijnhart
Copy link
Member

This is now happily ploughing away the backlog of old auditlogs on our production instance.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-2335-by-StefanRijnhart-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 91f6cb5 into OCA:12.0 May 25, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0200db1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants