Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig auto backup #2514

Closed
wants to merge 56 commits into from

Conversation

dani-xtendoo
Copy link

migration of the auto_backup module to version 16

Yenthe666 and others added 30 commits December 28, 2022 14:43
Added all the new fields and sentences. This will be the template for
translations.
Used to open  fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
- Follow template README.
- Remove HTML README.
- Move models to models folder.
- Model and view file names follow guidelines.
- Unused methods cleanup.
- Remove unneeded `.pot` file.
- Fix permissons.
- Follow PEP8 in names everywhere.
- Set more descriptive field names.
- Disable backups for other databases, for security.
- Remove db name from generated file, for easier cleanup.
- EAFP logic everywhere.
- More descriptive name.
- Data files moved to YAML, with cleaner ir.cron record creation.
- Add permissions for db.backup model.
- Icons.
- Update tests with new format.
- Storage method is a selectable, for easier extensibility.
- Instead of custom mailing, it just has a mail thread where you can subscribe.
- Should fix almost all comments in OCA#203.
- Reduce headers.

This respects the upstream license choice (GPL/AGPL) but reduces
verbosity.

It would be ideal to have everything under AGPL though.
* Add self.ensure_ones
* Add test coverage
* [10.0][auto_backup] Menu entry moved

* Update version in manifest
Currently translated at 58.2% (32 of 55 strings)

Translation: server-tools-11.0/server-tools-11.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/
Added test coverage
Added requirements.txt for pysftp
Added in the roadmap the exact version of pysftp for this to work (0.2.8)
Added in the roadmap the problem with list_db=False
Adapted calls to message_post
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/
Currently translated at 17.5% (14 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/
Currently translated at 26.2% (21 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
SimoneVagile and others added 21 commits December 28, 2022 14:43
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/
Currently translated at 80.2% (69 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 89.5% (77 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 94.1% (81 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 9.3% (8 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/ca/
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/es_AR/
Currently translated at 94.1% (81 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
Currently translated at 50.0% (43 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/hr/
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
Copy link

@manuelcalerosolis manuelcalerosolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

@dalonsod
Copy link
Contributor

Hello @dani-xtendoo , thanks for the contribution!

Inspecting commit history, last commit doesn't follow OCA's guidelines (see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0), could you take a look?

Thanks!

@chusamo chusamo mentioned this pull request Jun 5, 2023
31 tasks
@tafaRU tafaRU mentioned this pull request Sep 11, 2023
@tafaRU
Copy link
Member

tafaRU commented Sep 11, 2023

@OCA/tools-maintainers this could be closed in favour of #2712

@tafaRU
Copy link
Member

tafaRU commented Oct 6, 2023

@@OCA/tools-maintainers please see #2514 (comment) and update #2412

@thomaspaulb thomaspaulb closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.