Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][14.0] slow_wsgi_logger: log slow wsgi request #2607

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

petrus-v
Copy link
Contributor

@petrus-v petrus-v commented Apr 17, 2023

This module lets you log slow WSGI requests. It is useful to analysis
performance issue given more context regarding the request and
only log if processed time is higher to the defined limit.

@petrus-v petrus-v force-pushed the 14.0-add-log-slow-wsgi-request branch from 53269b4 to 6c49d54 Compare April 18, 2023 23:41
@petrus-v petrus-v marked this pull request as ready for review April 18, 2023 23:45
@petrus-v petrus-v changed the title [ADD] WIP slow_wsgi_logger: log slow wsgi request [ADD] slow_wsgi_logger: log slow wsgi request Apr 19, 2023
Copy link
Member

@damdam-s damdam-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 LGTM

@dreispt
Copy link
Member

dreispt commented Dec 9, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2607-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 9, 2023
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2607-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@thomaspaulb thomaspaulb changed the title [ADD] slow_wsgi_logger: log slow wsgi request [ADD][14.0] slow_wsgi_logger: log slow wsgi request Feb 14, 2024
@thomaspaulb
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@thomaspaulb
Copy link
Contributor

@petrus-v Tests are still failing

@petrus-v petrus-v force-pushed the 14.0-add-log-slow-wsgi-request branch from bb25bfb to 9a1bb66 Compare February 15, 2024 09:21
@dreispt
Copy link
Member

dreispt commented Apr 23, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2607-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 23, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2607-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

"fake.test",
"name_search",
wait,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing. Not quite sure what to make of it, to my best interpretation skills the fake.test model is not properly loaded, hence test fails and Odoo attempts to restore the savepoint but can't find it and the cursor is reset to an unusable state. The next query that has to do with registry restore, then also fails to execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants