-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] base_partition #2615
Conversation
are you sure AGPL is the best fit for such a module? It seems it's a small utility module that could have a broad usage and LGPL might fit better. If such module is AGPL, people not playing the AGPL game could easily just copy the feature instead of adopting the module and help to debug and maintain it... But of course this decision is up to you the authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Seems great. Minor comment
Agree with @rvalyi. Better to move to LGPL
This is a better implementation of https://github.com/odoo/odoo/blob/15.0/odoo/tools/misc.py#L260 |
d75ebf5
to
fb72b37
Compare
3d5794b
to
e07142b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code review)
A very useful addon heavily used in Odoo 10....
This PR has the |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
It looks like something changed on |
Congratulations, your PR was merged at 2f8f08f. Thanks a lot for contributing to OCA. ❤️ |
Migrtion from #1893.
This module adds a
partition(self, accessor)
method to every model.It accepts for accessor any parameter that would be accepted by
mapped
,i.e. a string
"field(.subfield)*"
or a function(lambda x: not x.b)
.It returns a dictionary with keys that are equal to
set(record.mapped(accessor))
,and with values that are recordsets.