-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] module_auto_update #2763
Conversation
7a8f3ee
to
2acb631
Compare
/ocabot migration module_auto_update |
@fkantelberg Could you retrigger the runboat with a rebase? |
Currently translated at 100.0% (4 of 4 strings) Translation: server-tools-15.0/server-tools-15.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_auto_update/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/es_AR/
Currently translated at 100.0% (5 of 5 strings) Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/es/
Currently translated at 60.0% (3 of 5 strings) Translation: server-tools-16.0/server-tools-16.0-module_auto_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/it/
2acb631
to
42894f7
Compare
@fkantelberg Looks like tests are failing in conjunction with |
@thomaspaulb True and I wonder why. I suspect that the tests of |
@fkantelberg After some investigation, found that database_cleanup tests are doing a commit And I think in previous versions this was noted also and solved by running tests in isolation or setting it as a rebel module. Maybe we can try the same here on 17.0? |
Sure lets try the rebel one :) |
Cool, will you cherry pick it as part of this PR? |
Seems to work. Not sure if I would rename the tests now to make it more descriptive. |
Renaming which tests in which way? |
The tests are currently named:
The cherry pick duplicated the existing tests BUT the first to only test |
Ahhhh yes. Well if they can be renamed, I would name the second one "Rebel tests with Odoo", it even sounds cool. But I wouldn't really know where to put it. If you do, and it's easy, then why not. |
c67d260
to
e233347
Compare
It's defined in Thanks for the support. |
@fkantelberg I don't see the addon hash tests running here in 17.0 either, so maybe this needs a cherry pick of #2847 |
I cherry picked the interesting parts of it and I see the tests now in the logs. Seems like Odoo runs tests differently than I do locally. |
What exactly did you cherry-pick though? I see the changes in the test file, but also changes in Contributors and other readme files |
cherry picked your linked commit. pre-commit did the rest but I squashed the commits. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 48bf5d8. Thanks a lot for contributing to OCA. ❤️ |
I had to adjust some tests because:
_patch_method
and_revert_method
i18n/en.po
in general