[FIX][9.0] auto_backup: Missing files #636
Conversation
|
Ok, thanks |
* Remove translations that were part of bad commits & now conflict with rebasing
Added all the new fields and sentences. This will be the template for translations.
Full translation of the module to Dutch
Add Chinese translations to the module. Written by talway.
Changed some translations
Thanks to Martin Schmid!
Flemish translations are identical to Dutch.
Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
Bump module version to 8.0.1.0.1
lasley
force-pushed
the
hotfix/9.0/auto_backup-commit_history
branch
from
3d6338a
to
8aea3ba
Compare
lasley
changed the title
|
I'm going to look at this in the next few days. I'm in conflict I guess I'm just going to start again, delete the migrations, then re-upgrade this module to 9. I really only needed it in 10 though, so bottom of my work stack TBH seeing as this is will be my third time migrating it to a version I don't need. |
lasley
force-pushed
the
hotfix/9.0/auto_backup-commit_history
branch
from
8aea3ba
to
e5f4ed8
Compare
|
Ok I think I got this to the state it was on merge on 9. There's this dirty hack I had to do in 8c45b49 to delete the translations that are already there so that the commits could be walked back onto the branch. It seems there are some missing translation files in this PR though, but everything that I do ends up with them not there. I'm hoping maybe that will correct itself when Transifex tries to update the branch? |
* Add self.ensure_ones * Add test coverage
lasley
force-pushed
the
hotfix/9.0/auto_backup-commit_history
branch
from
e5f4ed8
to
43ed6e8
Compare
|
Thanks @lasley 👍 |
|
Password for runbot: Admin:1234567890 |
|
@antespi With that password I can not authenticate in runbot |
|
Username is |
|
I'm probably going to provide a fix for that soon. Something to disable the security on the admin user unless an option is explicitly enabled I'm thinking |
|
I'm going to go ahead and merge this. It's pretty broken on 9.0 branch as it is & this was all approved a bunch of times, so I don't see the harm. Worse case scenario it's still broken, right? 😛 |
This reverts commit 0111be2, which was committed directly to 9.0 & pulled the files from #620 that contained an identical commit 8a078fc.
This is the cleanest way that I see to resolve #619 (comment).
The alternative is another migration, which will add another 50 some odd commits.
Anyone have thoughts?