-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server_environment module imports #93
Conversation
Quick fix to make `./odoo.py help` work without errors when the server_environment_files modules does not exist. Fixes OCA#89.
would |
Build fails when trying to run tests for server_environment. |
@nbessi Do you think you could spare a few minutes to have a look at this? |
@dreispt it may come form the fact that you removed the dependence on As far as I can see the setup still seems to be ok.
Regards Nicolas |
@nbessi Thanks for the pointers. I tried that, and when I try
|
_boolean_states = { | ||
'1': True, 'yes': True, 'true': True, 'on': True, | ||
'0': False, 'no': False, 'false': False, 'off': False} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreispt We have to add a way to check if module is installed here.
There is not need to raise an exception if module is not installed.
By default we wanted to ensure that setup is correct if module was installed and OpenERP should not boot if it is the case.
An option is to move the check later but it is more error prone.
Can't you move all of that to server.config._register_hook? This fail fail early enough if there is no configuration, but won't interfere if the module is not installed |
@hbrunn it causes errors in v8 even if the module is not installed - it's enough to be in the addons path.. Just try |
Yes, that's why I propose to move that code to _register_hook |
+1 for putting this in _register_hook if possible. |
Maybe the authors can provide a better fix and we close this? |
[IMP] monkey patch lxml's html cleaner
Quick fix to make
./odoo.py help
work without errors when theserver_environment_files modules does not exist.
Fixes #89.