Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] date_range: Migration to 14.0 #217

Merged
merged 47 commits into from
Oct 15, 2020

Conversation

feketemihai
Copy link
Member

No description provided.

lmignon and others added 30 commits October 9, 2020 16:57
* [ADD] Basic structure for the new date range module

* [IMP] Add a basic description into the README

* [IMP] Basic implementation

* [IMP] First working implementation

* [IMP] Improve datamodel

* [ADD] Add basic tests for date.range

* [PEP8]

* [PYLINT]

* [DEL] Remove unused code

* [IMP] Remove unsused dependencies into the JS

* [IMP] Better operator label for date range

* [DEL] Remove unused file

* [IMP] Better user experience by showing the select input only once empty

* [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters

* [FIX]Try to fix tests that fails only on travis by adding an explicit cast on the daterange methods parameters

* [FIX]Try to fix tests that fails only on travis by using postgresql 9.4

* [FIX]Try with postgresql 9.2 since the daterange method has appeared in 9.2

* [IMP] Add a limitation into the module description to warm about the minimal version of postgresql to use

* [IMP]Add multi-company rules

* [IMP]Remove unused files

* [FIX] Add missing brackets into JS

* [FIX] Overlap detection when company_id is False

* [IMP] Add default order for date.range

* [IMP] Add date range generator

* [FIX] OE compatibility

* [FIX] Travis

* [IMP] Code cleanup and improves test coverage

* [FIX] Add missing dependency on 'web'

* [PYLINT] remove unused import

* [FIX] Add missing copyright

* [FIX] Limits are included into the range

* [IMP][date_range] Security

* [IMP] Improve module description

* [IMP] Spelling
* Improve 'name' for generator wizard

  ir.rule should be active by default
* Don't auto-add '-' after prefix when generating date ranges via wizard
* code fine tuning suggested by Sylvain Garancher
Currently translated at 89.1% (41 of 46 strings)

Translation: server-ux-11.0/server-ux-11.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/ar/
If any module adds a required field on company, module fails. Executing it on
post_install, there's no problem.
Currently translated at 82.6% (38 of 46 strings)

Translation: server-ux-11.0/server-ux-11.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-date_range/da/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (46 of 46 strings)

Translation: server-ux-12.0/server-ux-12.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/it/
Currently translated at 100.0% (46 of 46 strings)

Translation: server-ux-12.0/server-ux-12.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-date_range/pt/
OCA-git-bot and others added 9 commits October 9, 2020 16:57
Currently translated at 76.1% (35 of 46 strings)

Translation: server-ux-13.0/server-ux-13.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-date_range/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-13.0/server-ux-13.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-date_range/
Currently translated at 100.0% (46 of 46 strings)

Translation: server-ux-13.0/server-ux-13.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-date_range/zh_CN/
We can't assign an empty recordset in a computed writable for a required field for
triggering DB fault, as previously this we get an akward error no in current
ORM status:

ERROR: operator does not exist: integer = boolean
LINE 12:                     AND dt.type_id=false;
                                           ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.

so let's simply trigger in this case the check of the company consistency, which is
legit and the final expected result.

I have added an extra test for testing the company consistency the other way around.
@feketemihai feketemihai mentioned this pull request Oct 9, 2020
19 tasks
@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@feketemihai feketemihai changed the title 14.0 mig date range [14.0][MIG] date_range: Migration to 14.0 Oct 12, 2020
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot 👍

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-217-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 16571b7 into OCA:14.0 Oct 15, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b375685. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.