Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] mig date_range #414

Merged
merged 79 commits into from
Dec 17, 2021
Merged

[15.0][MIG] mig date_range #414

merged 79 commits into from
Dec 17, 2021

Conversation

JoanMForgeFlow
Copy link
Contributor

Supersede #401

@HaraldPanten
Copy link

@pedrobaeza could you approve workflows here? THX.

@koenloodts koenloodts mentioned this pull request Dec 7, 2021
Closed
8 tasks
@HaraldPanten
Copy link

@JoanMForgeFlow could you check pre-commit?

@JoanMForgeFlow
Copy link
Contributor Author

@JoanMForgeFlow could you check pre-commit?

done!

HaraldPanten
HaraldPanten approved these changes Dec 10, 2021
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@ValentinVinagre @pedrobaeza

@ValentinVinagre ValentinVinagre mentioned this pull request Dec 10, 2021
Merged
1 task
@HaraldPanten
Copy link

@pedrobaeza do you mind merging this one in order to continue with the migration of --> OCA/account-financial-reporting#837 ?

THX!

AaronHForgeFlow
AaronHForgeFlow reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok. Can you include the improvements of #413 ?

@pedrobaeza pedrobaeza mentioned this pull request Dec 11, 2021
Closed
9 tasks
pedrobaeza
pedrobaeza requested changes Dec 11, 2021
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes from #413

@pedrobaeza
Copy link
Member

/ocabot migration date_range

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 11, 2021
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 11, 2021
Closed
34 tasks
@HaraldPanten
Copy link

@JoanMForgeFlow @AaronHForgeFlow could you continue with the migration, please? We need to keep working in other modules depending on this one. 🙏

THX!

@JoanMForgeFlow
Copy link
Contributor Author

@JoanMForgeFlow @AaronHForgeFlow could you continue with the migration, please? We need to keep working in other modules depending on this one. pray

THX!

yes!

@JoanMForgeFlow
Copy link
Contributor Author

Missing changes from #413

@pedrobaeza I am trying to import the odoo_test_helper library, in the test-requirements.txt file, and it gives me the following error. Any idea how to fix it
Captura de pantalla de 2021-12-15 12-34-32
?

@sbidoul
Copy link
Member

sbidoul commented Dec 15, 2021

@JoanMForgeFlow just add odoo-test-helper in a test-requirements.txt file at the repo root.

@JoanMForgeFlow
Copy link
Contributor Author

@JoanMForgeFlow just add odoo-test-helper in a test-requirements.txt file at the repo root.

@sbidoul I had already tried it and it doesn't work, that's why I was asking.

@sbidoul
Copy link
Member

sbidoul commented Dec 15, 2021

@JoanMForgeFlow it should work. Please retry and we'll look at the exact log/error.

@JoanMForgeFlow
Copy link
Contributor Author

JoanMForgeFlow commented Dec 16, 2021 •
edited
Loading

@JoanMForgeFlow it should work. Please retry and we'll look at the exact log/error.

@sbidoul It worked!

@JoanMForgeFlow
Copy link
Contributor Author

Missing changes from #413

@pedrobaeza @AaronHForgeFlow I have already joined the pending PRs, but now I am going to solve the last commit since I have accidentally joined it with the pre-commit.

@JoanMForgeFlow JoanMForgeFlow force-pushed the 15.0-mig-date_range branch 3 times, most recently from c540e14 to 723fb28 Compare December 16, 2021 11:34
StefanRijnhart and others added 15 commits December 17, 2021 11:16
@StefanRijnhart @JoanMForgeFlow
[IMP] date_range: fully automatic generation from date range types
4e44081
@StefanRijnhart @JoanMForgeFlow
[RFR] date_range: convert wizard onchange to stored compute methods
bfb472e
@StefanRijnhart @JoanMForgeFlow
[IMP] date_range: add a search mixin class
8e80855
@astirpe @JoanMForgeFlow
[FIX] Do not break super() calls on fields_view_get()
df7c42d
@joao-p-marques @JoanMForgeFlow
[FIX] date_range: Add comment to missing dependency for odoo_test_helper
ef0cd4f
@dzungtran89 @JoanMForgeFlow
[FIX] invalid value when doing test
173097b
@dzungtran89 @JoanMForgeFlow
[IMP] date_range: black, isort, prettier
458e007
@oca-travis @JoanMForgeFlow
[UPD] Update date_range.pot
01cc31d
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
07b0dbe
@oca-transbot @JoanMForgeFlow
Update translation files
82df71d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-14.0/server-ux-14.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-date_range/
@oca-travis @JoanMForgeFlow
[UPD] Update date_range.pot
d08e7e8
@OCA-git-bot @JoanMForgeFlow
[UPD] README.rst
b3c6a70
@OCA-git-bot @JoanMForgeFlow
date_range 14.0.2.1.0
4a83377
@oca-transbot @JoanMForgeFlow
Update translation files
9ae5787 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-14.0/server-ux-14.0-date_range
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-date_range/
@JoanMForgeFlow
[15.0][IMP] date_range: black, isort, prettier
cdf969f
@JoanMForgeFlow
Copy link
Contributor Author

voilá https://pypi.org/project/odoo-test-helper/2.0.1/

Thank you so much :)

@HaraldPanten
Copy link

@pedrobaeza GO? 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-414-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2beed5d into OCA:15.0 Dec 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e12d286. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-mig-date_range branch December 17, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow left review comments

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.