-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] base_substate: Migration to 17.0 #885
base: 17.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (34 of 34 strings) Translation: server-ux-16.0/server-ux-16.0-base_substate Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_substate/es/
Currently translated at 100.0% (34 of 34 strings) Translation: server-ux-16.0/server-ux-16.0-base_substate Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_substate/it/
@achulii Code review LGTM, however there are some warnings in the tests that need to be addressed. Additionally some commits need to be squashed, so i will be also able to test the functionality through the runboat. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
LGTM, some minor comments:
Can you please check this warning?
2024-05-16 11:00:30,502 249 WARNING odoo odoo_test_helper.fake_model_loader: Wrong Import in module base_substate, the class <class 'odoo.addons.base_substate.tests.sale_test.SaleTest'> have been already imported.
Please take a look to the README on how to import test class
2024-05-16 11:00:30,502 249 WARNING odoo odoo_test_helper.fake_model_loader: Wrong Import in module base_substate, the class <class 'odoo.addons.base_substate.tests.sale_test.SaleTest'> have been already imported.
Please take a look to the README on how to import test class
2024-05-16 11:00:30,502 249 WARNING odoo odoo_test_helper.fake_model_loader: Wrong Import in module base_substate, the class <class 'odoo.addons.base_substate.tests.sale_test.LineTest'> have been already imported.
Please take a look to the README on how to import test class
2024-05-16 11:00:39,253 249 WARNING odoo odoo.fields: Field base.substate.test.sale.substate_id: unknown parameter 'tracking', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2024-05-16 11:00:39,444 249 WARNING odoo odoo.fields: Translated stored related field (date.range.type_name) will not be computed correctly in all languages
2024-05-16 11:00:39,445 249 WARNING odoo odoo.fields: Field base.substate.test.sale.substate_id: unknown parameter 'tracking', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
As discovered in:
OCA/account-invoicing#1595 (comment)
This module uses wrong spelling and is inconsistent.
It occurs at multiple places. Can you please add a separate commit, to correct Sub State
to Substate
.
Is this a followup of #855 ? |
No description provided.