[17.0][MIG] base_substate: Migration to 17.0 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (34 of 34 strings) Translation: server-ux-16.0/server-ux-16.0-base_substate Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_substate/es/
Currently translated at 100.0% (34 of 34 strings) Translation: server-ux-16.0/server-ux-16.0-base_substate Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_substate/it/
|
@achulii Code review LGTM, however there are some warnings in the tests that need to be addressed. Additionally some commits need to be squashed, so i will be also able to test the functionality through the runboat. 
|
bosd
suggested changes
Jul 17, 2024
There was a problem hiding this comment.
Thanks for your work on this!
LGTM, some minor comments:
Can you please check this warning?
2024-05-16 11:00:30,502 249 WARNING odoo odoo_test_helper.fake_model_loader: Wrong Import in module base_substate, the class <class 'odoo.addons.base_substate.tests.sale_test.SaleTest'> have been already imported.
Please take a look to the README on how to import test class
2024-05-16 11:00:30,502 249 WARNING odoo odoo_test_helper.fake_model_loader: Wrong Import in module base_substate, the class <class 'odoo.addons.base_substate.tests.sale_test.SaleTest'> have been already imported.
Please take a look to the README on how to import test class
2024-05-16 11:00:30,502 249 WARNING odoo odoo_test_helper.fake_model_loader: Wrong Import in module base_substate, the class <class 'odoo.addons.base_substate.tests.sale_test.LineTest'> have been already imported.
Please take a look to the README on how to import test class
2024-05-16 11:00:39,253 249 WARNING odoo odoo.fields: Field base.substate.test.sale.substate_id: unknown parameter 'tracking', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
2024-05-16 11:00:39,444 249 WARNING odoo odoo.fields: Translated stored related field (date.range.type_name) will not be computed correctly in all languages
2024-05-16 11:00:39,445 249 WARNING odoo odoo.fields: Field base.substate.test.sale.substate_id: unknown parameter 'tracking', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
As discovered in:
OCA/account-invoicing#1595 (comment)
This module uses wrong spelling and is inconsistent.
It occurs at multiple places. Can you please add a separate commit, to correct Sub State to Substate.
|
Is this a followup of #855 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.