-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sign_oca: Ensure inalterability #15
Conversation
f4d3259
to
1efb54b
Compare
Now this should be ready for review. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This one has conflicts. |
207eab3
to
20fc79e
Compare
20fc79e
to
b96db12
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b96db12
to
1908a2f
Compare
1908a2f
to
f4ba409
Compare
Maybe it is time for merge /ocabot merge major |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 486a59a. Thanks a lot for contributing to OCA. ❤️ |
This change should allow us to make an inalterable signature item, making it much easier for us.
With
sign_oca
andsign_biometric_oca
we should be able to have and advanced signature following eIDAS, making it legal