Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sign_oca: Ensure inalterability #15

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

etobella
Copy link
Member

@etobella etobella commented Dec 3, 2023

This change should allow us to make an inalterable signature item, making it much easier for us.

With sign_oca and sign_biometric_oca we should be able to have and advanced signature following eIDAS, making it legal

@etobella etobella marked this pull request as ready for review December 17, 2023 07:10
@etobella etobella changed the title [ADD] sign_inalterability_oca [IMP] sign_oca: Ensure inalterability Dec 17, 2023
@etobella
Copy link
Member Author

Now this should be ready for review.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Apr 21, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 22, 2024
@pedrobaeza
Copy link
Member

This one has conflicts.

sign_oca/data/sequence.xml Outdated Show resolved Hide resolved
sign_oca/models/sign_oca_request.py Outdated Show resolved Hide resolved
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Aug 25, 2024
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etobella
Copy link
Member Author

Maybe it is time for merge

/ocabot merge major

@OCA-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-15-by-etobella-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1cc1a89 into OCA:16.0 Aug 25, 2024
7 checks passed
@OCA-git-bot
Copy link

Congratulations, your PR was merged at 486a59a. Thanks a lot for contributing to OCA. ❤️

@etobella etobella deleted the 16.0-inalterability branch October 17, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants