Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mail_show_follower #1132

Merged
merged 21 commits into from
Sep 22, 2023
Merged

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Apr 20, 2023

standard migration

@bosd bosd marked this pull request as ready for review April 20, 2023 12:15
@bosd bosd mentioned this pull request Apr 20, 2023
38 tasks
@rafaelbn
Copy link
Member

rafaelbn commented Jun 3, 2023

/ocabot migration mail_show_follower

Nota: This module has bugs in previous versions not solved.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 3, 2023
@bosd
Copy link
Contributor Author

bosd commented Jun 23, 2023

Nota: This module has bugs in previous versions not solved.

You have a link to the issue?
Should this pr be converted to draft?

@cliffkujala
Copy link

I am willing to sponsor this to help get it merged to v16.

@EmilioPascual
Copy link

@bosd can you make rebase? Runboat isn't run, with rebase it must run.

@EmilioPascual
Copy link

Nota: This module has bugs in previous versions not solved.

You have a link to the issue? Should this pr be converted to draft?

Issue: #970
However, this issue should not stop this migration.

ValentinVinagre and others added 21 commits September 21, 2023 07:53
Display CC according to notification_type
Currently translated at 100.0% (7 of 7 strings)

Translation: social-12.0/social-12.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_show_follower/fr/
As commented in OCA#788 the PR should be merged manually but we should update the version of the module as a minor update

cc @ValentinVinagre @eLBati @MiquelRForgeFlow @HaraldPanten
Co-authored-by: Miquel Raïch <miquel.raich@eficent.com>
Added settings to customize notification and translations to important parts of the message.

[FIX] Security fixes and simplified customization

Field `show_followers_partner_format` formatted with %(param)s
Removed CSS customizations

[FIX] README options

[FIX] Index.html configure

[FIX] Several changes

- Removed unnecesary properties on res_config_settings
- Markup safe on partner_format
- Use email_domain_extract instead own one
When using composer, doesn't include all recipients of the message on the notification.
In the highly improbable but actually possible and real world case that a partner has more than one user associated, this change makes the emails able to send.

@moduon MT-1634
@bosd bosd force-pushed the 16.0-mig-mail_show_follower branch from 69c8b19 to 99696d1 Compare September 21, 2023 05:54
@bosd
Copy link
Contributor Author

bosd commented Sep 21, 2023

@bosd can you make rebase? Runboat isn't run, with rebase it must run.

Done 😄

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosd
Copy link
Contributor Author

bosd commented Sep 21, 2023

I am willing to sponsor this to help get it merged to v16.

@cliffkujala No sponsorship needed for now. But you could help leaving a review.

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1132-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e6e9446 into OCA:16.0 Sep 22, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f764894. Thanks a lot for contributing to OCA. ❤️

@bosd
Copy link
Contributor Author

bosd commented Sep 22, 2023

@CasVissers-360ERP

CC: @espo-tony
It's Done

@bosd bosd deleted the 16.0-mig-mail_show_follower branch September 22, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.