-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] mail_show_follower #1132
Conversation
/ocabot migration mail_show_follower Nota: This module has bugs in previous versions not solved. |
You have a link to the issue? |
I am willing to sponsor this to help get it merged to v16. |
@bosd can you make rebase? Runboat isn't run, with rebase it must run. |
Issue: #970 |
Display CC according to notification_type
Currently translated at 100.0% (7 of 7 strings) Translation: social-12.0/social-12.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_show_follower/fr/
As commented in OCA#788 the PR should be merged manually but we should update the version of the module as a minor update cc @ValentinVinagre @eLBati @MiquelRForgeFlow @HaraldPanten
Co-authored-by: Miquel Raïch <miquel.raich@eficent.com>
[REF] Compact comment
Added settings to customize notification and translations to important parts of the message. [FIX] Security fixes and simplified customization Field `show_followers_partner_format` formatted with %(param)s Removed CSS customizations [FIX] README options [FIX] Index.html configure [FIX] Several changes - Removed unnecesary properties on res_config_settings - Markup safe on partner_format - Use email_domain_extract instead own one
When using composer, doesn't include all recipients of the message on the notification.
In the highly improbable but actually possible and real world case that a partner has more than one user associated, this change makes the emails able to send. @moduon MT-1634
69c8b19
to
99696d1
Compare
Done 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cliffkujala No sponsorship needed for now. But you could help leaving a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code & functional review
/ocabot merge patch
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at f764894. Thanks a lot for contributing to OCA. ❤️ |
CC: @espo-tony |
standard migration