-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] mail_tracking_mailgun: Migration to 17.0 #1410
[17.0][MIG] mail_tracking_mailgun: Migration to 17.0 #1410
Conversation
09eda0e
to
9f1440c
Compare
/ocabot migration mail_tracking_mailgun |
@@ -78,8 +78,8 @@ def _mailgun_values(self): | |||
if not api_key: | |||
raise ValidationError(_("There is no Mailgun API key!")) | |||
api_url = icp.get_param("mailgun.api_url", "https://api.mailgun.net/v3") | |||
catchall_domain = icp.get_param("mail.catchall.domain") | |||
domain = icp.get_param("mailgun.domain", catchall_domain) | |||
catchall_domain = self.env["mail.alias.domain"].search([], limit=1).name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be adapted for all the possible domains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is done just to get a default value if an specific one isn't set in the settings.
…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
Both Carlos and me have work a lot in this module, maybe not coding but much testing and definition in usability
When this method is called without an event (a.k.a. `event=None`), this method produces the following error: ``` Traceback (most recent call last): File "/opt/odoo/auto/addons/mail/models/mail_mail.py", line 278, in send res = IrMailServer.send_email(msg, mail_server_id=mail.mail_server_id.id) File "/opt/odoo/auto/addons/mail_tracking/models/ir_mail_server.py", line 88, in send_email tracking_email.smtp_error(self, smtp_server_used, e) File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 213, in smtp_error self.sudo()._partners_email_bounced_set('error') File "/opt/odoo/auto/addons/mail_tracking/models/mail_tracking_email.py", line 203, in _partners_email_bounced_set ]).email_bounced_set(self, reason, event=event) File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 22, in email_bounced_set self._email_bounced_set(reason, event) File "/opt/odoo/auto/addons/mail_tracking_mailgun/models/res_partner.py", line 33, in _email_bounced_set event['Message-Id'] or '') TypeError: 'NoneType' object has no attribute '__getitem__' ``` So, we now assume we do not always have an event.
- Configurable partner email auto check.
Currently translated at 16.7% (4 of 24 strings) Translation: social-11.0/social-11.0-mail_tracking_mailgun Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking_mailgun/fr/
- In case the sending domain is different from the one configured in the mail.domain.catchall setting.
46e4499
to
c4679be
Compare
c4679be
to
9301a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1410-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
On my way to merge this fine PR! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1410-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
On my way to merge this fine PR! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1410-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 2ad83c5. Thanks a lot for contributing to OCA. ❤️ |
Pending:
Doing practical tests with sandbox API keyscc @Tecnativa TT49914