-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] stock_inventory_revaluation #118
[ADD] stock_inventory_revaluation #118
Conversation
|
||
* Go to *Inventory / Configuration / Products / Product Categories* and | ||
define, for each category, a Valuation Increase Account and a Valuation | ||
Decrease Account. These accounts will be used as contra-accounts to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/contra/counterpart
@jbeficent I am a little confused, this feature is already working on odoo (at least conceptually what you mentioned), can you share with us which is the difference between your approach and the one in odoo? Thanks. |
_name = 'stock.inventory.revaluation.line.get.quant' | ||
_description = 'Inventory revaluation line get Quants' | ||
|
||
date_from = fields.Date('Date From') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From?
Until?
Overall LGTM! |
@nhomar, I can't really find now in Odoo the feature tha allows one to change the cost of a quant, with the subsequent accounting entries. Support for change of standard and average is possible in odoo, but only through a wizard. If you want to apply a revaluation for many products it's not user friendly. That's why I thought of integrating thw whole inventory revaluation in one place. This is really a mimick of SAP B1 inventory revaluation tool. Seehttps://m.youtube.com/watch?v=CWUizZ8Twpk |
@nhom also the contra account of inventory revaluation in standard is wrong. It's not correct to use stock input and stock output! The user should be able to define, and the proposal should be different from stock in/out |
@jbeficent Well we just finished a huge reevaluation inventory process in a 10k SKU company with 4 subsidiaries. I need to say "yes" to the fact that some stuff was done in order to achieve such process. For example, in th SAP video you just show I have a quick question (which is the main concern of my question). The example number you are putting there is the one you set actually on the standard_cost field, and the wizard is necesary in order to achieve the account move topics. IF we are talking of 1 product IMHO If I reevaluate the inventory the stock in/out account is the one affected and teh ones of dofference account (all already in odoo). You can see some little fixes we did here and we ran a cronjob in order to set the new standard for those which depends of a BoM price, but all using the original objects, no new fields, no new behaviors just "fixes". That's my point here is that may be I am not seeing correctly the value of the new feature, and I want to be enlghted whether you are right or we forgot something huge on our side ;-) As a side Note. With those approached I am showing you we achieve have consistent: Accounting - Quants - Sotck Moves. All say the same in the moment th cronjob runs, and all account moves are generatd accordingly with correct NIIF approach (nothing special just to say a pretty name to what odoo is doing right now). It should be GREAT if you share a little video of your approach, because I think that the account you are adding to the category is not necesary (but may be I am worng) and I think the actual Odoo'd algorithms only need little fixes (and not the creation of a new one). But YES this is a hard topic our analysis, and deployed results took to us something like 4 months in order to follow all the auditory and so on (well we manage financially segmentation costs but that's another history). If you want we can have a little meeeting in spanish to understand better and maybe we can help on this PR a little bit more. Regard.s |
@nhomar In your module product_extended_variants:
Odoo's module product_extended:
No tool in Odoo now supports inventory revaluation under the real cost method. That is, change the cost of the quants. The module proposed here covers all possible scenarios of price revaluation, and ideally, once Odoo has proper support for price change with ability to define what GL account should be use, we could call the same wizard from this module, and thus this would really represent another way to achieve the same thing. Another option is to fix / alter the standard methods offered by odoo for standard & average (possibly using a 'hooks' module that overrides the standard), and we build a separate tool for inventory revaluation specifically suited for the 'real' cost method. Perhaps it's better from a consistency perspective. Your feedback is welcome here. I'm not sure that I see how your approach can achieve Accounting = Quants = Stock Moves. When you change a standard price of a product (standard or average price) the cost of quants is really not changing. And that's fine, because you're not operating under real cost method. Note that the field 'Inventory Value' of a quant is calculated field that gives you the product's standar price under standard / average and the true cost of the quant under real cost method. From your statements I can see that your use case of inventory revaluation dealt with standard prices in raw materials and finished products. I have the same issue, where a company has screwed inventory valuation due to lack of proper maintenance of standard prices. That's why I'm going for a real costing approach, where you ensure that COGS will be recognized under FIFO costing method, which is the most accurate method of COGS recongition and inventory valuation as well. |
@nhomar I'd be more than happy to discuss this with you in a meeting. You can reach me on skype or Hangouts. |
Hi, That's a very good work, again @jbeficent thank you for all your work. The only remark, such a module would deserve a little test IMO as it really have important impact. Otherwise LGTM 👍 Regards, Joël |
[ADD] : Added Test Cases to stock_inventory_revaluation.
For some reason Runbot is killed with the following error message: |
Runbot is killed because I created a branch from 9.0, not from 8.0. I'm closing this PR and creating a separate one, #121, that uses the correct 8.0 branch. |
Stock Account Inventory Revaluation
If your company runs a perpetual inventory system, you may need to perform
inventory revaluation.
You can re-valuate inventory values by:
and inventory value is recalculated according to the new price. In case of
real price, you can select which quants you want to change the price on.
unchanged, resulting in a change in the price.
Configuration
define, for each category, a Valuation Increase Account and a Valuation
Decrease Account. These accounts will be used as contra-accounts to the
Stock Valuation Account during the inventory re-valuation.
Usage
to create a new Inventory Revaluation.