[15.0][MIG] stock_putaway_product_template: Migration to 15.0 #1448
Conversation
|
/ocabot migration stock_putaway_product_template |
|
@cesar-tecnativa Could you reword/rearrange your migration commit and solve tests ? |
cesar-tecnativa
force-pushed
the
15.0-mig-stock_putaway_product_template
branch
from
bf816e9
to
cee7591
Compare
done |
cesar-tecnativa
force-pushed
the
15.0-mig-stock_putaway_product_template
branch
2 times, most recently
from
c033e47
to
c0962a3
Compare
There was a problem hiding this comment.
@cesar-tecnativa For next time, don't forget to make version change appears in migration commit, not formatting one.
… you already set a product template TT34143
sergio-teruel
force-pushed
the
15.0-mig-stock_putaway_product_template
branch
from
c0962a3
to
37b669b
Compare
|
@rousseldenis Fixed change version in migration commit |
| ): | ||
| return super( | ||
| StockLocation, self.with_context(filter_putaway_rule=True) | ||
| )._get_putaway_strategy(product, quantity, package, packaging, additional_qty) |
There was a problem hiding this comment.
Please use always keyword arguments when they are of that type. This ways, you keep compatibility with **kwargs form
| )._get_putaway_strategy(product, quantity, package, packaging, additional_qty) | |
| )._get_putaway_strategy(product, quantity=quantity, package=package, packaging=packaging, additional_qty=additional_qty) |
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/stock-logistics-warehouse/tree/14.0/stock_putaway_product_template |
There was a problem hiding this comment.
Please redo the README with 15.0 instead of 14.0, or let the previous one and let the bot to do the change. It's for not having double diff.
sergio-teruel
force-pushed
the
15.0-mig-stock_putaway_product_template
branch
from
37b669b
to
167fd26
Compare
|
Changes done!! |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at cd38537. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT36572