Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] stock_available_immediately: Migration to 15.0 #1507

Closed
wants to merge 26 commits into from

Conversation

glitchov
Copy link
Contributor

No description provided.

nbessi and others added 25 commits October 11, 2022 10:10
(lp:c2c-addons/6.1  rev 28.1.10)
…PL-3 with author agreement, improved help messages and pep8

(lp:c2c-addons/6.1  rev 45.1.8)
[UPG] Upgraded to version 8, fixed references to new 8.0  views and  moved fields that were in  product.product to product.template

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPG] stock available immediately, corrected the calculation method of
immediately_usable_qty to take in accountthe sign change in outgoing_qty
(from negative to positive) in version 8.

[FLAKE8]

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[UPD] move out from unported to 8 for update

[fix] remove duplicate view and correct view name

[UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0.

[FIX] renaming of a class, comment removing, useless code.
Generic module to compute the stock quantity available to promise using several implementations.
stock_available_immediatly is changed to become the first optional implementation.
Cherry pick of commit 0b060f6 from the v7 branch

[IMP] stock_available* uses new API

[IMP] READMEs and TODOs

Cherry-picked from v7 at 8add4be

Conflicts:
	__unported__/stock_available_mrp/__openerp__.py
	stock_available/__openerp__.py
	stock_available_immediately/__openerp__.py
…uct and

product.template, now takes in account variants and correctly displays value.
[FLAKE8]

Removing duplicate modules and moving README.rst into __unported__
* fix the dependencies for the computed field

* use api.multi instead of api.one to avoid calling
  super()._immediately_usable_qty in a loop (this improves perfs on a tree view
  display)
There are cases where we dot NOT want to simply sum the quantities of all the
variants. For example when dealing with manufacturing capacities, we may have
to chose between variants because we can't make ALL of them with the same
components.

So instead of a simple non-modular implementation, we'll let each module define
his own implementation of how to compute the product template's quantity
available for sale.

Conflicts:
	stock_available/__openerp__.py
	stock_available_immediately/__openerp__.py
optimize stock computation by avoiding to call useless compute
Due to merge mess, we need to restore current code this way
* New README by fragments
* Bump manifest version
* Adapted tests
� This is the 1st commit message:

[IMP] stock_available_immediately: black, isort, prettier

� The commit message #2 will be skipped:

� [UPD] README.rst
@oca-clabot
Copy link

Hey @glitchov, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@rousseldenis
Copy link
Contributor

/ocabot migration stock_available_immediately

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 11, 2022
80 tasks
@glitchov glitchov force-pushed the 15.0-mig-stock_available_immediately branch from 8afd733 to f0158a6 Compare October 11, 2022 10:45
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1507-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 14, 2022
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1507-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

It seems this one is collapsing with sale_stock_available_info_popup, as it contains tests that expects the usual behavior of stock_available, not this modified one. One possible technique is to not enable the feature if in test mode (not config["test_enable"]) and not testing this exact module (through a context key check).

How this was done in 13.0 that both coexist?

@victoralmau
Copy link
Member

Superseed by #1588

@pedrobaeza pedrobaeza closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.