Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_inventory_discrepancy: Migration to version 15.0 #1683

Merged
merged 15 commits into from
Apr 6, 2023

Conversation

ernestotejeda
Copy link
Member

@ernestotejeda ernestotejeda commented Apr 5, 2023

Cc @Tecnativa TT36993

I made this 'PR' apart from #1573 because it has a different approach. I have based more on the native odoo 15 approach to do the inventory adjustment and not make the functionalities of this module dependent on the new stock_inventory OCA module.

Main changes:

  • The access group that gives rights to make inventory adjustments is now independent of the stock 'user' group
  • Discrepancy threshold fields are now displayed on stock.quant tree view and highlighted when the threshold is excceded.
  • Applying an inventory adjustment (adjustment in stock.quant) both from an inventory line and from the button in the header of the stock.quant tree view, will launch an alert wizard showing the quants with discrepancy and only users with the access group 'Validate Inventory Adjustments exceeded threshold' can proceed to apply the adjustment from this wizard.
  • Adapt tests.

ping @carlosdauden @sergio-teruel @pedrobaeza

@ernestotejeda ernestotejeda force-pushed the 15.0-mig-stock_inventory_discrepancy branch from 1673b4e to 0f8ce6f Compare April 5, 2023 14:48
@ernestotejeda
Copy link
Member Author

@carlosdauden @rousseldenis changes done

Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review!

Great job!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@pedrobaeza
Copy link
Member

/ocabot migration stock_inventory_discrepancy

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 6, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 6, 2023
80 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#1278) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1573.
Perhaps you should check that there is no duplicate work.
CC : @Chanakya-OSI

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1683-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e513b03. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.